adding a system call

[mohit verma]

hi mulyadi,

i used syscall number 264 . and for the coding standard  , can u tell me
where am i  off the track ?



On Tue, Feb 22, 2011 at 11:20 PM, Mulyadi Santosa <mulyadi.santosa at gmail.com
> wrote:

> On Tue, Feb 22, 2011 at 22:18, mohit verma <mohit89mlnc at gmail.com> wrote:
> > hi all ,
> >>
> >> i followed the link and tried to add a system call in kernel-version
> >> 2.6.37
> >> here is the code :
> >>
> >>
> >> #include<linux/linkage.h>
> >> #include<linux/kernel.h>
> >> #include<linux/fs.h>  //for getname
> >> #include<linux/err.h> //for PTR_ERR
> >> asmlinkage int sys_hariohm(const char __user *filename)
> >> {
> >>     char *tmp = getname(filename);
> >>      int fd=PTR_ERR(tmp);
> >>         if (!IS_ERR(tmp))
> >>         {
> >>         printk("filename %s \n",tmp);
> >>         putname(tmp);
> >>         return fd;
> >>         }
> >>         else
> >>         {
> >>         return 2;
> >>         }
> >> }
>
> which syscall number did you assigned to this syscall? and exactly how
> do you assign it?
>
> NB: your code style doesn't follow the Linux kernel coding standart....
>
> --
> regards,
>
> Mulyadi Santosa
> Freelance Linux trainer and consultant
>
> blog: the-hydra.blogspot.com
> training: mulyaditraining.blogspot.com
>



-- 
........................
*MOHIT VERMA*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20110222/193b6a1e/attachment-0001.html