Re: Build Error in Linux-next, intel ethernet driver
I updated my clean untouched linux-next tree, and tried to compile with the attached .config. But I got a build error with intel i40e driver. I tested a fix, and sent to LKML. But I don't have this device, I compiled and tested the kernel. Boots normally. Anyone had the same issue ? Thanks Lucas Tanure Fix missing include in intel i40e driver. Without this include linux next tree won't compile. Signed-off-by: Lucas Tanure <tanure@linux.com> --- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c index 6938fc1..5d01db1 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c @@ -33,6 +33,7 @@ #include <scsi/fc/fc_fcoe.h> #include <scsi/libfc.h> #include <scsi/libfcoe.h> +#include <uapi/linux/dcbnl.h> #include "i40e.h" #include "i40e_fcoe.h" -- 2.0.0
On Tue, Aug 5, 2014 at 9:25 AM, Lucas Tanure <tanure@linux.com> wrote:
I updated my clean untouched linux-next tree, and tried to compile with the attached .config.
Your .config got stripped from the mail, can you please send me your .config.
But I got a build error with intel i40e driver.
I tested a fix, and sent to LKML. But I don't have this device, I compiled and tested the kernel. Boots normally.
Anyone had the same issue ?
I have not been testing linux-next, but I do test David Miller's net-next and net tree's which compile just fine with allmodconfig. In the short term, I have added your patch to my queue so that our validation team can take a look at the issue. Please send me your .config so that we can reproduce your issue to ensure that your patch is the best solution for this issue.
Thanks Lucas Tanure
Fix missing include in intel i40e driver. Without this include linux next tree won't compile.
Signed-off-by: Lucas Tanure <tanure@linux.com> --- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c index 6938fc1..5d01db1 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c @@ -33,6 +33,7 @@ #include <scsi/fc/fc_fcoe.h> #include <scsi/libfc.h> #include <scsi/libfcoe.h> +#include <uapi/linux/dcbnl.h>
#include "i40e.h" #include "i40e_fcoe.h" --
Hi, Thanks for reviewing my patch. My .config was bigger than 40k ( max attachment size for kernelnewbies list). The quick way to share is through dropbox. https://www.dropbox.com/s/kyeecunmebouysk/config.xz Thanks -- Lucas Tanure +55 (19) 988176559 On Tue, Aug 5, 2014 at 6:44 PM, Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
On Tue, Aug 5, 2014 at 9:25 AM, Lucas Tanure <tanure@linux.com> wrote:
I updated my clean untouched linux-next tree, and tried to compile with the attached .config.
Your .config got stripped from the mail, can you please send me your .config.
But I got a build error with intel i40e driver.
I tested a fix, and sent to LKML. But I don't have this device, I compiled and tested the kernel. Boots normally.
Anyone had the same issue ?
I have not been testing linux-next, but I do test David Miller's net-next and net tree's which compile just fine with allmodconfig. In the short term, I have added your patch to my queue so that our validation team can take a look at the issue. Please send me your .config so that we can reproduce your issue to ensure that your patch is the best solution for this issue.
Thanks Lucas Tanure
Fix missing include in intel i40e driver. Without this include linux next tree won't compile.
Signed-off-by: Lucas Tanure <tanure@linux.com> --- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c index 6938fc1..5d01db1 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c @@ -33,6 +33,7 @@ #include <scsi/fc/fc_fcoe.h> #include <scsi/libfc.h> #include <scsi/libfcoe.h> +#include <uapi/linux/dcbnl.h>
#include "i40e.h" #include "i40e_fcoe.h" --
participants (2)
-
Jeff Kirsher -
Lucas Tanure