Bad Patches and Issues with other devolopers
I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick
Hmm. What about stop sending patches? On Aug 5, 2014 7:43 PM, "Nick Krause" <xerofoify@gmail.com> wrote:
I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick
_______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Hi Nick, I came across some G+ posts from kernel developers discussing you and your recent patch submissions. I must say you're pretty (in)famous! :) Jokes aside, why not just follow on the advice given to you by so many people, i.e pick an area of interest (in the various kernel subsystems) for yourself, first pick really small ossues (but not the code formatting ones as they only tend to generate noise for the maintainer and not really fix anything), create the patch, see if the kernel builds with. TEST IT, most importantly (if you don't have the requisite hw then either acquire one, or pick another issue where you CAN test it). Basically check everything thats mentioned here: https://www.kernel.org/doc/Documentation/SubmittingPatches http://kernelnewbies.org/OPWfirstpatch Trust me, if you _do_ go through this process and submit a 'good' patch, all past issues that you've had with other developers will be forgotten. Don't be in a rush to get 'something' in the kernel. I know its a big deal to get things in one of the coolest piece of software on this planet, but you'll need a lot perseverance and patience to be a kernel contributor. HTH, -mandeep On Tue, Aug 5, 2014 at 10:42 AM, Nick Krause <xerofoify@gmail.com> wrote:
I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick
_______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
On Tue, Aug 5, 2014 at 1:59 PM, Mandeep Sandhu <mandeepsandhu.chd@gmail.com> wrote:
Hi Nick,
I came across some G+ posts from kernel developers discussing you and your recent patch submissions. I must say you're pretty (in)famous! :)
Jokes aside, why not just follow on the advice given to you by so many people, i.e pick an area of interest (in the various kernel subsystems) for yourself, first pick really small ossues (but not the code formatting ones as they only tend to generate noise for the maintainer and not really fix anything), create the patch, see if the kernel builds with. TEST IT, most importantly (if you don't have the requisite hw then either acquire one, or pick another issue where you CAN test it). Basically check everything thats mentioned here:
https://www.kernel.org/doc/Documentation/SubmittingPatches http://kernelnewbies.org/OPWfirstpatch
Trust me, if you _do_ go through this process and submit a 'good' patch, all past issues that you've had with other developers will be forgotten.
Don't be in a rush to get 'something' in the kernel. I know its a big deal to get things in one of the coolest piece of software on this planet, but you'll need a lot perseverance and patience to be a kernel contributor.
HTH, -mandeep
On Tue, Aug 5, 2014 at 10:42 AM, Nick Krause <xerofoify@gmail.com> wrote:
I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick
_______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
That's fine, I feel perhaps I am just really trying to force my code in(ego) and just is bad form. If anyone on this list can read my last trace to check my logic first, before I write a patch and let you check it, that would be great. Thanks A lot, Nick
On Tue, Aug 5, 2014 at 7:04 PM, Nick Krause <xerofoify@gmail.com> wrote:
On Tue, Aug 5, 2014 at 1:59 PM, Mandeep Sandhu <mandeepsandhu.chd@gmail.com> wrote:
Hi Nick,
I came across some G+ posts from kernel developers discussing you and your recent patch submissions. I must say you're pretty (in)famous! :)
Jokes aside, why not just follow on the advice given to you by so many people, i.e pick an area of interest (in the various kernel subsystems) for yourself, first pick really small ossues (but not the code formatting ones as they only tend to generate noise for the maintainer and not really fix anything), create the patch, see if the kernel builds with. TEST IT, most importantly (if you don't have the requisite hw then either acquire one, or pick another issue where you CAN test it). Basically check everything thats mentioned here:
https://www.kernel.org/doc/Documentation/SubmittingPatches http://kernelnewbies.org/OPWfirstpatch
Trust me, if you _do_ go through this process and submit a 'good' patch, all past issues that you've had with other developers will be forgotten.
Don't be in a rush to get 'something' in the kernel. I know its a big deal to get things in one of the coolest piece of software on this planet, but you'll need a lot perseverance and patience to be a kernel contributor.
HTH, -mandeep
On Tue, Aug 5, 2014 at 10:42 AM, Nick Krause <xerofoify@gmail.com> wrote:
I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick
_______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
That's fine, I feel perhaps I am just really trying to force my code in(ego) and just is bad form. If anyone on this list can read my last trace to check my logic first, before I write a patch and let you check it, that would be great. Thanks A lot, Nick
_______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
How about not sending patches at all until you develop a good understanding of kernel subsystems. read the books and read code for few months before you ever re-try sending patches? -- Thank you Warm Regards Anuz
On Aug 5, 2014 11:14 PM, "Nick Krause" <xerofoify@gmail.com> wrote:
I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick
i saw that you sent a patch regarding videobuf2 on 3rd august , the reaction of that patch continues till 4th. on 4th you write that you will not send a patch again without testing. but surprisingly again on 5th you send a patch , which as usual , fails to build. have you really tested the patch before sending?? did you try to compile the kernel after making your modifications?? i think - no.
_______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
On Tue, Aug 5, 2014 at 11:55 PM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
On Aug 5, 2014 11:14 PM, "Nick Krause" <xerofoify@gmail.com> wrote:
I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick
i saw that you sent a patch regarding videobuf2 on 3rd august , the reaction of that patch continues till 4th. on 4th you write that you will not send a patch again without testing. but surprisingly again on 5th you send a patch , which as usual , fails to build. have you really tested the patch before sending?? did you try to compile the kernel after making your modifications?? i think - no.
_______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
_______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Hi Nick, The advice developers have given you is very valuable. As the above ppl have also said, please do hurry through submitting incorrect patches, you should really know what you are fixing and why that needs to be fixed. It should be compiled and tested. Above all, you need to ask yourself a question, why do you really want to do this? Please do not do this if you want to be famous or show that even you can do something technical. Do this only if you are really interested and have liking about OS development & stuff. Then it will not matter that you have submitted 100s of patches in a month or just 1 patch in a year. Results should not matter, your goal should be to learn something new every day about linux kernel. This should be done through lots of conceptual & code reading, using & testing the kernel. To start of please read good books like : - 1. Linux kernel development 2. Understanding linux kernel 3. Linux device drivers 4. There are more but these 3 are enough for beginning. Once done, you would be interested in particular sub-system, then try to explore that sub-system more by code reading, making small changes not necessarily bug-fixes, validate your code understanding through those changes. Enjoy learning! - Rohan
On Tue, 05 Aug 2014 13:42:58 -0400, Nick Krause said:
I have sent out just ten bad patches and the developers seem very annoyed with me and
Let's face it - if you've sent ten bad patches in a row without getting one right, you're doing something wrong. And although total noob coders scale very well (there seems to be a never-ending supply of them), maintainers don't scale well at all - and they have a *huge* workload to review a lot of patches every release cycle. I can't think of a single maintainer that isn't willing to provide advice. I also can't think of a single maintainer who *doesn't* get torqued off massively when V2 of a patch, or another patch, comes in from the same person and it's obvious the advice wasn't listened to. They don't have time for that sort of foolishness.
think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great.
First and foremost, when senior kernel developers give you specific advice, *listen to it*. If somebody like Ted T'so tells you that it's unacceptable to send patches that aren't compile-tested, *you should never be sending another patch that didn't compile clean*. Period. End Of Discussion. In fact, you should strive higher - don't submit a patch unless you are (a) booted onto the patched kernel, (b) verify it by checking uname -r, and (c) have done testing that your patch actually fixed the issue you were patching without breaking anything. Running around willy-nilly submitting patches all over the tree doesn't inspire confidence in your patches - especially after you've hit multiple subsystems and been told "This is wrong and you obviously (a) don't understand the subsystem and (b) didn't bother figuring it out". Also, you may want to sit down for a few days, and think long and hard about *why* you're so desperate to submit kernel patches. Do you have a good reason to devote the time? Or is it just ego-stroking? (Personally, I've been around since the 2.5.47 or so kernel - and I'm only doing it because I have a Dell laptop on my desk and a quarter acre of servers across the hall, and lots of users on our campus - and every good bug report I file against linux-next means a crappy bug report from a user after the release escapes)
On Tue, Aug 5, 2014 at 3:54 PM, <Valdis.Kletnieks@vt.edu> wrote:
On Tue, 05 Aug 2014 13:42:58 -0400, Nick Krause said:
I have sent out just ten bad patches and the developers seem very annoyed with me and
Let's face it - if you've sent ten bad patches in a row without getting one right, you're doing something wrong. And although total noob coders scale very well (there seems to be a never-ending supply of them), maintainers don't scale well at all - and they have a *huge* workload to review a lot of patches every release cycle.
I can't think of a single maintainer that isn't willing to provide advice.
I also can't think of a single maintainer who *doesn't* get torqued off massively when V2 of a patch, or another patch, comes in from the same person and it's obvious the advice wasn't listened to. They don't have time for that sort of foolishness.
think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great.
First and foremost, when senior kernel developers give you specific advice, *listen to it*. If somebody like Ted T'so tells you that it's unacceptable to send patches that aren't compile-tested, *you should never be sending another patch that didn't compile clean*. Period. End Of Discussion.
In fact, you should strive higher - don't submit a patch unless you are (a) booted onto the patched kernel, (b) verify it by checking uname -r, and (c) have done testing that your patch actually fixed the issue you were patching without breaking anything.
Running around willy-nilly submitting patches all over the tree doesn't inspire confidence in your patches - especially after you've hit multiple subsystems and been told "This is wrong and you obviously (a) don't understand the subsystem and (b) didn't bother figuring it out".
Also, you may want to sit down for a few days, and think long and hard about *why* you're so desperate to submit kernel patches. Do you have a good reason to devote the time? Or is it just ego-stroking? (Personally, I've been around since the 2.5.47 or so kernel - and I'm only doing it because I have a Dell laptop on my desk and a quarter acre of servers across the hall, and lots of users on our campus - and every good bug report I file against linux-next means a crappy bug report from a user after the release escapes)
I want to help and improve the code plus get a code doing kernel development. I understand now and am not going to waste time anymore, I am going to make sure all my patches are tested correctly and to the best of my ability first. Regards NIck
participants (7)
-
Anuz Pratap Singh Tomar -
Kristofer Hallin -
Mandeep Sandhu -
Nick Krause -
Rohan Puri -
Sudip Mukherjee -
Valdis.Kletnieks＠vt.edu