Move EXPORT_SYMBOL() macros in kobject.c from the end of the file next to the function definitions to which they belong. Signed-off-by: Gabriel Somlo <somlo@cmu.edu> --- On Mon, Aug 10, 2015 at 11:54:00AM -0700, Greg KH wrote:
EXPORT_SYMBOL(kset_register); EXPORT_SYMBOL(kset_unregister); +EXPORT_SYMBOL(kset_find_obj);
checkpatch doesn't like this for obvious reasons :)
When I run checkpatch on this one, it comes back fine. Could you please elaborate ?
[staging]$ scripts/checkpatch.pl 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch total: 0 errors, 0 warnings, 4 lines checked
0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch has no obvious style problems and is ready for submission.
EXPORT_SYMBOL() should be below the function definition itself, not at the bottom of the file. Odd that checkpatch doesn't catch this when done in this manner, it will if you run it on the whole file after your patch is applied (along with the existing problems.)
BTW, when I did that, I was merely trying to immitate what was already in lib/kobject.c. So here's making sure the next person won't get confused the same way I did... :) Thanks much, --Gabriel lib/kobject.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index 3e3a5c3..0554077 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -568,6 +568,7 @@ void kobject_del(struct kobject *kobj) kobject_put(kobj->parent); kobj->parent = NULL; } +EXPORT_SYMBOL(kobject_del); /** * kobject_get - increment refcount for object. @@ -584,6 +585,7 @@ struct kobject *kobject_get(struct kobject *kobj) } return kobj; } +EXPORT_SYMBOL(kobject_get); static struct kobject * __must_check kobject_get_unless_zero(struct kobject *kobj) { @@ -675,6 +677,7 @@ void kobject_put(struct kobject *kobj) kref_put(&kobj->kref, kobject_release); } } +EXPORT_SYMBOL(kobject_put); static void dynamic_kobj_release(struct kobject *kobj) { @@ -803,6 +806,7 @@ int kset_register(struct kset *k) kobject_uevent(&k->kobj, KOBJ_ADD); return 0; } +EXPORT_SYMBOL(kset_register); /** * kset_unregister - remove a kset. @@ -815,6 +819,7 @@ void kset_unregister(struct kset *k) kobject_del(&k->kobj); kobject_put(&k->kobj); } +EXPORT_SYMBOL(kset_unregister); /** * kset_find_obj - search for object in kset. @@ -1051,10 +1056,3 @@ void kobj_ns_drop(enum kobj_ns_type type, void *ns) kobj_ns_ops_tbl[type]->drop_ns(ns); spin_unlock(&kobj_ns_type_lock); } - -EXPORT_SYMBOL(kobject_get); -EXPORT_SYMBOL(kobject_put); -EXPORT_SYMBOL(kobject_del); - -EXPORT_SYMBOL(kset_register); -EXPORT_SYMBOL(kset_unregister); -- 2.4.3