On Wed, Jun 22, 2022 at 06:20:04AM +0200, Philipp Hortmann wrote:
On 6/7/22 19:23, Greg KH wrote:
And again, please help review code, otherwise you are just asking others to do work for you, which if you think about it, could be construed as a bit selfish, and I don't think you mean it to be.
Hi Greg,
this applies to me. I promise to improve. But this topic is not enough advertised. Everywhere information about patches can be found. But how to do a correct Reviewed-by: or Tested-by: is not so good documented.
I bought hardware to improve and did one "Tested-by:" of the patch:
[PATCH v2 0/5] Fixed some coding style issues and spelling from Chang Yu <marcus.yu.56@gmail.com>
https://lore.kernel.org/linux-staging/91c9a0de-76f8-37fb-31b4-4401a6e35d48@g...
Did I do something wrong or was I just unlucky?
Is 24 hours quick enough response?
Sometimes, yes, it is. Other times I get to patches quicker than that as I batch them up and process them once or twice a week. You just got unlucky and reviewed it after I had applied the changes, but that was not the case for your other series you reviewed today. thanks for the review, it's always appreciated. greg k-h