March 15, 2017
11:12 a.m.
Alexander Kapshuk <alexander.kapshuk@gmail.com> writes:
On Wed, Mar 15, 2017 at 10:31 AM, Tobin C. Harding <me@tobin.cc> wrote:
why does calling pr_debug() with more than one argument cause a sparse warning?
drivers/mmc/core/sdio_io.c:70:9: error: unknown field name in initializer
sdio_io.c:70: pr_debug("SDIO: Enabling device %s...\n", sdio_func_id(func)); .. 'sdio_func_id()' is a macro defined here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/inc... #define sdio_func_id(f) (dev_name(&(f)->dev))
So the "func" in that debug call contains a 'struct device'. Any reason why the pr_debug() shouldn't be converted to something like dev_dbg(&func->dev, "SDIO: Enabling device...\n"); ? Bjørn