On Wed, 11 Aug 2021 08:26:42 +0200 Christoph Hellwig <hch@lst.de> wrote:
On Mon, Aug 09, 2021 at 06:50:44PM -0500, Ian Pilcher wrote:
On 8/9/21 5:43 PM, Marek Behún wrote:
I confess that I am not very familiar with internal blkdev API.
It's mainly a matter of symbol visibility. See this thread from a few months ago:
https://www.spinics.net/lists/linux-leds/msg18244.html
Now ... my code currently lives in block/, so there isn't actually anything technically preventing it from iterating through the block devices.
The reactions to Enzo's patch (which you can see in that thread) make me think that anything that iterates through all block devices is likely to be rejected, but maybe I'm reading too much into it.
I think the main issue with this series is that it adds a shitload of code and a hook in the absolute I/O fastpath for fricking blinkenlights. I don't think it is even worth wasting time on something this ridiculous.
That's why I think we should do this the way the netdev trigger does. Periodically reading block_device's stats, and if they are greater, blink the LED. Marek