Re: drivers/char/efirtc.c - efi_rtc_open\ efi_rtc_close

On Mon, Jan 21, 2019 at 03:40:31PM +0530, Muni Sekhar wrote:

Hello All,

The drivers/char/efirtc.c file has ‘struct file_operations.open’ & ‘struct file_operations.close’ functions efi_rtc_open()\ efi_rtc_close() does nothing, just returns ‘0’.

So it accept multiple open files at the same time. If we don’t define these empty function, still driver accepts multiple open() calls at the same time, right?

If so I’d like to know what is the advantage of keeping these function which does nothing instead of removing it from driver?

There is no advantage at all, those functions can be removed safely, no need to have them at all. Care to send a patch for this? thanks, greg k-h