-----Original Message----- From: kernelnewbies-bounces@kernelnewbies.org [mailto:kernelnewbies- bounces@kernelnewbies.org] On Behalf Of Nick Krause Sent: Wednesday, August 13, 2014 11:03 AM To: Valdis Kletnieks Cc: Max Filippov; kernelnewbies; Manish Katiyar Subject: Re: [PATCH] staging: Check for Null return of allocated skb in fw_download_code
Seems to be called a lot. In addition I can only build test this as I don't have the hardware. Cheers Nick
This code is a device driver. I may be an old fuddy-duddy in this regard, but I don't inflict my code on others until I've tested it. If you don't have the hardware, you can't have tested it. I think your patch is thus premature. If you are unable to obtain the hardware for testing, you might want to consider working on parts of the kernel that are hardware independent. Jeff Haran