El día 14 de febrero de 2012 02:06, Greg KH <greg@kroah.com> escribió:
On Tue, Feb 14, 2012 at 01:47:52AM -0300, Ezequiel García wrote:
2. second, I am fixing some style issues (besides checkpatch), for instance "if" syntax:
- if (0 == bInterfaceNumber) { + if (bInterfaceNumber == 0) {
You do know why the first style was chosen, right?
This driver code has this "if" style on every if clause. Perhaps author's taste? Don't know. Searching at kernel code I haven't seen this kind of "if" style.
That's not saying your change is incorrect, but odds are, there are bigger things that need to be fixed up first.
I know. It is difficult for me to refrain from cleaning ugly code :( Perhaps I should just stick to function split up for now?
So, Am I on the right track?
Close, how about: /* Get properties of probed interface */ instead?
Ok. Thanks a lot, Ezequiel.