On Fri, 21 Aug 2020, Joe Perches wrote:
On Fri, 2020-08-21 at 23:35 -0400, Valdis Klētnieks wrote:
On Fri, 21 Aug 2020 18:08:08 -0700, Joe Perches said:
(forwarding on to kernel-janitors/mentees and kernelnewbies)
Just fyi for anyone that cares:
A janitorial task for someone might be to use Julia's coccinelle script below to convert the existing instances of commas that separate statements into semicolons.
Note that you need to *really* check for possible changes in semantics. It's *usually* OK to do that, but sometimes it's not...
for (i=0; i++, last++; !last) {
changing that comma to a ; will break the compile. In other cases, it can introduce subtle bugs.
True enough for a general statement, though the coccinelle script Julia provided does not change a single instance of for loop expressions with commas.
As far as I can tell, no logic defect is introduced by the script at all.
The script has a rule to ensure that what is changed is part of a top level statement that has the form e1, e2;. I put that in to avoid transforming cases where the comma is the body of a macro, but it protects against for loop headers as well. julia