Hi, I'm try to fix staging/easycap driver. I know it has some bugs somewhere (I've seen some panics while using the device) but I wanted to improve the code style before debugging it. In the meantime, I expect to develop a better understanding of the code. However, I want know if I am in the right direction; so I want to know if this is ok: 1. mainly I am splitting very large functions into smaller parts. For instance, xxx_probe function is +1k lines long, so I'm splitting it up to make the code cleaner, more readable. Is this ok? 2. second, I am fixing some style issues (besides checkpatch), for instance "if" syntax: - if (0 == bInterfaceNumber) { + if (bInterfaceNumber == 0) { and ugly comments like: -/*---------------------------------------------------------------------------*/ -/* - * GET PROPERTIES OF PROBED INTERFACE - */ -/*---------------------------------------------------------------------------*/ + + /* + * GET PROPERTIES OF PROBED INTERFACE + */ So, Am I on the right track? Thanks, Ezequiel.