Re: A very stupid question about formatting a patch :)

On Thu, Aug 18, 2016 at 12:46:30PM +0300, Aleksander Alekseev wrote:

Hello.

When I do `git format-patch` I get something like this:

``` Documentation/kselftest.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/kselftest.txt b/Documentation/kselftest.txt index 979eaca..54bee77 100644 (SNIP) ```

Note an empty line between statistics and patch itself. Judging by lkml.org _everyone_ removes this empty line. So my question is --- is there really such a requirement for formatting a patch or it's just something that depends on git version?

I don't see anyone removing that line, perhaps you aren't looking at the patch properly in an email client? Leave it in there, it's good to have. thanks, greg k-h