On Wed, Apr 28, 2021 at 05:43:29PM +0530, Anupama K Patil wrote:
On 21/04/28 02:48PM, Leon Romanovsky wrote:
On Wed, Apr 28, 2021 at 05:10:57PM +0530, Anupama K Patil wrote:
On 21/04/28 01:11PM, Greg KH wrote:
On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote:
isapnp code is very old and according to this link https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications from Wikipedia, even Windows Vista disabled ISA PnP by default.
This change is in follow up to https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u
Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com>
Has the maintainer said this is unsupported?
That's who you should take suggestions from :)
thanks,
greg k-h
Leon said he thinks it is unsupported (I've also cc'd him). So, I've sent this patch to get the feedback from the maintainer.
Leon said something different. https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#m6c83... ------
If changes to ISA code aren't welcomed, should these be marked obsolete in the MAINTIANERS file?
I think so, but think that "Odd Fixes" better describes that Rafael wrote. ------ Sorry about that! but does checkpatch tell people not to send patches if it's 'Odd fixes'?
I don't think so, but people should check MAINTIANERS file before they send patches and it has an explanation what "Odd fixes" means.
Should I wait for the maintainer's reply before doing anything else?
Yes, please
Thanks, Anupama