Need help determining if the change is warranted.
Anton Gusev
aagusev at ispras.ru
Mon Mar 27 07:34:33 EDT 2023
In the file drivers/leds/flash/leds-lm3601x.c, function
lm3601x_strobe_set, the calls to regmap_update_bits aren't checked for
errors.
I am unsure whether adding the checks is warranted, since
lm3601x_read_faults might cover the conditions that can cause
regmap_update_bits to fail there. On the other hand, if this is not
true, then lm3601x_strobe_set can fail silently. Also, all other calls
to regmap_update_bit in the driver are checked or directly returned.
--
Anton Gusev
More information about the Kernelnewbies
mailing list