How to comment or reply to others?

Konstantin Ryabitsev konstantin at linuxfoundation.org
Mon Jul 12 14:22:01 EDT 2021


On Sun, Jul 04, 2021 at 11:13:08AM +0200, Abd-Alrhman Masalkhi wrote:
> hello jim, thanks for your reply, I think that my question has not some
> useful information, I should have specify the problem more clearly
> 
> I am having some trouble replying and comment on threads in the Linux Kernel
> Mailing List, I have submitted some patches and then I have received some
> comments from reviews, I tried to reply to them by just prefixing the
> subject line with "Re:"
> 
> First, I made some changes and commit them using:
> 
> git commit -a
> 
> Then I have formatted the commit using:
> 
> git format-patch master..fix-warning
> 
> After that, I have edit the output from:
> 
> Subject: [PATCH] description-of-the-patch
> 
> to:
> 
> Subject: Re: [PATCH] description-of-the-patch

This is not the workflow you should be using, as most developers do not care
to have the new revision of the patch be threaded to the previous version. Try
the following:

    git format-patch -v2 master..fix-warning

You may then open the resulting file and add extra information at the bottom
of the commit message, right before the diffstat like so:

    ---
    v2:
     - Fixed compiler warning

    v1:
     - Link: https://lore.kernel.org/r/message-id-of-the-previous-patch

    foo/somefile.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

For example, see this patch for your reference:
https://lore.kernel.org/lkml/20210707055652.962-1-yao.jin@linux.intel.com/

If you then require v3 of the patch, just use the same format, copy-paste
previous changelog data and add v3, e.g.:

    ---
    v3:
     - Fixed something else

    v2:
     - Fixed compiler warning
     - Link: https://lore.kernel.org/r/message-id-of-v2-patch

    v1:
     - Link: https://lore.kernel.org/r/message-id-of-v1-patch

Not everyone posts links to the previous patch revisions, but this will
certainly help the maintainer if they need to review the actual patch
difference.

Best regards,
Konstantin



More information about the Kernelnewbies mailing list