[PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

Walt Feasel waltfeasel at gmail.com
Sat Nov 26 13:02:14 EST 2016


On Sat, Nov 26, 2016 at 06:19:22PM +0100, Greg KH wrote:
> On Sat, Nov 26, 2016 at 11:56:17AM -0500, Walt Feasel wrote:
> > On Sat, Nov 26, 2016 at 12:05:50PM +0100, Greg KH wrote:
> > > On Sat, Nov 26, 2016 at 03:43:18AM -0500, Walt Feasel wrote:
> > > > Make checkpatch modifications to include:
> > > > 
> > > > Multiple blank lines
> > > > Blank line after declarations
> > > > Space after cast
> > > > WARN_ON vs BUG_ON
> > > > Align parenthesis
> > > > Comparison to NULL
> > > > Line continuations
> > > > 
> > > > Walt Feasel (7):
> > > >   security: apparmor: apparmorfs.c Multiple blank lines
> > > >   security: apparmor: apparmorfs.c Blank line after declarations
> > > >   security: apparmor: apparmorfs.c Space after cast
> > > >   security: apparmor: apparmorfs.c WARN_ON vs BUG_ON
> > > >   security: apparmor: apparmorfs.c Align parenthesis
> > > >   security: apparmor: apparmorfs.c Comparison to NULL
> > > >   security: apparmor: apparmorfs.c Line continuations
> > > 
> > > Why are you sending apparmor patches to the kernelnewbies list and not
> > > the maintainers and subsystem list for this code instead?
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > Because as stated in my patch notes I am not sure how to
> > fix certain cases.
> > I have not been able to find reference material other than
> > other patches and discussions for certain cases and have
> > to try and reason why.
> > You wanted me to move out of staging so I have looked to
> > other areas but do not wish to send in ridiculous patches
> > and have me seen as being malicious.
> > Since this is kernelnewbies mailing list isn't that it's
> > purpose or am I move on again?
> > Feel free to skip my post should they trouble you.
> 
> Just send the patches to the proper people and list that
> get_maintainer.pl shows you to, that's all, no need to bother
> kernelnewbies with it.
> 
> good luck!
> 
> greg k-h
So kernelnewbies is not to be used to learn about how to fix
checkpatch type warning?



More information about the Kernelnewbies mailing list