Patch Series

[Geyslan G. Bem]

Hello,

2016-02-16 10:38 GMT-03:00 Roger H Newell <newell.roger at gmail.com>:
> Hi all:
>
> I have a question about creating a patch series. I'm working in
> drivers/staging/wilc1000 fixing code style. If for example 2 errors are
> reported by checkpatch.pl error A and error B, it seems logical that I could
> fix all occurrences of error A as one patch and all occurrences of error B
> in a second patch.
>
> My question is, is it OK to fix all occurrences of error A across the files
> inside drivers/staging/wilc1000 as one patch and all occurrences of error B
> across all files inside drivers/staging/wilc1000 as a second patch?

I think it is. But you must rely on the maintainer's choice. Ask
him/her before sending.

>
> The alternative would be to create a patch that fixes all errors of A and a
> patch that fixes all errors of B per file ? In some cases there are so many
> occurrences of a particular error across files it probably does make more
> sense to create the patches per file.
>
> Any thoughts or clarifications on this ?

Ditto. But each case must be evaluated. Some changes (error A and B)
can be done in one line, so you have to analyze them.
A real case would be nice for a better exemplification.
>
> Cheers:
> Roger H. Newell
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>



-- 
Regards,

Geyslan G. Bem
hackingbits.com