CHECK: Alignment should match open parenthesis

Nicholas Mc Guire der.herr at hofr.at
Fri Mar 13 09:28:02 EDT 2015


On Fri, 13 Mar 2015, palik imre wrote:

> On Friday, 13 March 2015, 13:43, Nicholas Mc Guire <der.herr at hofr.at> wrote:
> > On Fri, 13 Mar 2015, palik imre wrote:
> > 
> > 
> > > Sorry for the silly question, but I have some issues with this checkpatch.pl warning.
> > >
> > > I mean Documentation/CodingStyle says:
> > >
> > > Outside of comments, documentation and except in Kconfig, spaces are never
> > > used for indentation, and the above example is deliberately broken.
> > >
> > > But checkpatch.pl claims I should align to open parentheses.  These two things seem to be contradictory to me.  Could somebody clarify this?
> > 
> > >
> > leading tabs *followed* by spaces to align parameters to a function are fine
> 
> The emacs settings in Documentation/CodingStyle seem to contradict to you,
> as it is set up to use c-lineup-arglist-tabs-only
>
The problem is that CodingStyle does not explicitly address
parameter alignment for functions that do not fit on a single line
but checkpatch.pl does

you can try it out - if you align to the opening braces with spaces
with preceding TABs it will not fuss and this is also common practice.

thx!
hofrat



More information about the Kernelnewbies mailing list