CHECK: Alignment should match open parenthesis

palik imre imre_palik at yahoo.co.uk
Fri Mar 13 09:09:29 EDT 2015


On Friday, 13 March 2015, 13:43, Nicholas Mc Guire <der.herr at hofr.at> wrote:
> On Fri, 13 Mar 2015, palik imre wrote:
> 
> 
> > Sorry for the silly question, but I have some issues with this checkpatch.pl warning.
> >
> > I mean Documentation/CodingStyle says:
> >
> > Outside of comments, documentation and except in Kconfig, spaces are never
> > used for indentation, and the above example is deliberately broken.
> >
> > But checkpatch.pl claims I should align to open parentheses.  These two things seem to be contradictory to me.  Could somebody clarify this?
> 
> >
> leading tabs *followed* by spaces to align parameters to a function are fine

The emacs settings in Documentation/CodingStyle seem to contradict to you,
as it is set up to use c-lineup-arglist-tabs-only

> but for basic block indentation you never use spaces. so
> 
>     func(param1,
>         param2);
> 
> would be allowed but not
> 
>     if (something) {
>         if(something else) {
> 
> HTH
> 
> thx!
> hofrat



More information about the Kernelnewbies mailing list