My kernel patch was rejected with comments

Tobin C. Harding me at tobin.cc
Wed Mar 22 06:32:10 EDT 2017


On Wed, Mar 22, 2017 at 12:24:47PM +0530, Prasant J wrote:
> Hi,
> 
> I submitted a kernel patch and it was rejected with comments from
> maintainer. Is it important to reply with a new patch against
> maintainers response mail? Or it it ok if I send a new email with the
> updated patch?

You don't send the new patch as a reply. You may, if you wish, reply
to the maintainer (or reviewer) with some comments that you understand
and intend on implementing their suggestions (and thanks) or
disagreeing as it may be.

You then re-work your patch and submit it as normal using git
send-email. But you put v2 in the subject.  You can use

git format-patch -X --subject-prefix='PATCH v2' --numbered --cover-letter

(where X is the number of commits to add to the series, assuming it is
a series).

In the cover letter add a section stating the changes since v1, for
example

v1 -> v2
 - use foo() instead of bar()

If it is a single patch, you may wish to just edit the subject
manually. Make sure you put the version change information below the
--- line so it is not included if/when the patch gets merged.

Good luck,
Tobin.

> 
> 
> I have mutt and git send-mail setup but I can only send mail with
> those. How do I reply to a maintainers comment?
> 
> 
> I manually copied Message-ID from gmail web GUI and tried using it in
> "--in-reply-to" with git send email but when I saw the linux mailing
> list, it did weird things. It sent a blank reply to maintainers email
> and sent a new mail with my updated patch.
> 
> 
> Is there any tutorial on how can a I setup my workflow?
> 
> 
> Any inputs will be of great help here!
> 
> 
> Regards, Pj
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies



More information about the Kernelnewbies mailing list