[PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods

Bjørn Mork bjorn at mork.no
Sat Nov 26 16:28:11 EST 2016

Greg KH <greg at kroah.com> writes:
> On Sat, Nov 26, 2016 at 01:02:14PM -0500, Walt Feasel wrote:
>> So kernelnewbies is not to be used to learn about how to fix
>> checkpatch type warning?
> Maybe, but really, if you have a well-formed patch, just send it to the
> correct maintainers, it's up to them to accept it or not, that's their
> job :)

And I think the most important reason for doing that is because only
they can answer the questions.  You need to know what the code does to
be able to answer things like "is it OK to replace BUG_ON with WARN_ON
here?". Although that is preferable according to checkpatch, it's not
necessarily a 1-to-1 replacement. The error path changes, and the
existing code is likely not tested or developed with the new path in

Nobody(?) in kernelnewbies knows anything about the apparmor code.  It's
not that we don't want to answer. We just can't.


More information about the Kernelnewbies mailing list