skb_clone related query

Jeff Haran Jeff.Haran at
Tue Jan 5 12:22:52 EST 2016

> -----Original Message-----
> From: kernelnewbies-bounces at [mailto:kernelnewbies-
> bounces at] On Behalf Of pavi1729
> Sent: Monday, January 04, 2016 10:12 PM
> To: Jeff Haran
> Cc: kernelnewbies at
> Subject: Re: skb_clone related query
> Jeff,
>    I have submitte a fix for the same on linux-usb and netdev mailing list. Just
> waiting for review.
> Please review the same.
> Cheers,
> Pavi

The logic looks right to me, though I think a style Nazi might object to the lack of a space between the "if" the leading parenthesis. If it was me I'd put some braces around the call to dev_kfree_skb_any(), though I don't know if would complain about that one or not.

Jeff Haran

More information about the Kernelnewbies mailing list