Submitted a first patch and no reply

Valdis.Kletnieks at Valdis.Kletnieks at
Thu Jan 8 15:49:27 EST 2015

On Thu, 08 Jan 2015 12:37:15 -0800, shirish gajera said:

> That's hwy I just fix one warning.

That means "don't fix a warning about indentation *and* a  warning
about trailing blanks in the same patch".

Also, if you're fixing a style issue, you should actually *review* the
code, and make sure you fix the issue everywhere, *even if the other ones
didn't prompt a warning*.

It's interesting that the warning only popped on the one case where the
"/* looping version */" is on a separate line, not on the #else line.

Am cc'ing Joe Perches for that question. Joe - to get you up to speed,
checkpatch was run against drivers/staging/skein/skein_block.c, and it
flagged one definition of the macro R256, but not the other one, or the
two definitions each for R512 and R1024.  Any idea why?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : 

More information about the Kernelnewbies mailing list