Forget this patch ( Error with checkpatch)

Nick Krause xerofoify at gmail.com
Wed Aug 13 15:58:27 EDT 2014


On Wed, Aug 13, 2014 at 3:55 PM, Nick Krause <xerofoify at gmail.com> wrote:
> On Wed, Aug 13, 2014 at 3:54 PM, Nicholas Krause <xerofoify at gmail.com> wrote:
>> This patch fixes the bug , https://bugzilla.kernel.org/show_bug.cgi?id=60461
>> on the kernel bugzilla. Further more I am checking if we are allocating a
>> NULL skb and if so make rt_status to false and free the quene we are using
>> for allocated skbs in the while/do loop with skb_quene_purge.
>>
>> Signed-off-by: Nicholas Krause <xerofoify at gmail.com>
>> ---
>>  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
>> index 1a95d1f..0f18c6d 100644
>> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
>> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
>> @@ -61,6 +61,11 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
>>                 }
>>
>>                 skb  = dev_alloc_skb(frag_length + 4);
>> +               if (skb == NULL ) {
>> +                       rt_status = false;
>> +                       skb_queue_purge(&priv->rtllib->skb_waitQ[TXCMD_QUEUE]);
>> +                       break;
>> +               }
>>                 memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
>>                 tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
>>                 tcb_desc->queue_index = TXCMD_QUEUE;
>> --
>> 1.9.1
>>
> If there are any other errors with this patch, please let me known. I
> checked again and there are no warnings or build errors.
> Sorry to Valdis about the stupid questions.
> Nick

Checkpatch error please forget.
Nick



More information about the Kernelnewbies mailing list