[PATCH] staging: Check for Null return of allocated skb in fw_download_code

Nick Krause xerofoify at gmail.com
Wed Aug 13 14:27:59 EDT 2014


On Wed, Aug 13, 2014 at 2:25 PM, Jerry Snitselaar <dev at snitselaar.org> wrote:
> On Wed Aug 13 14, Max Filippov wrote:
>> On Wed, Aug 13, 2014 at 10:03 PM, Nick Krause <xerofoify at gmail.com> wrote:
>> > I did test my patch by doing a kernel build and I get this error,
>> > drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c:66:4: error:
>> > implicit declaration of function ‘skb_quene_purge’
>> > [-Werror=implicit-function-declaration]
>> >     skb_quene_purge(&priv->rtllib->skb_waitQ[tcb_desc->queue_index]);
>> > I am wondering how do I fix this, I will attach my patch so I can fix
>> > this out and send a proper patch :).
>>
>> Typo, skb_queue_purge.
>>
>
> I imagine that array index isn't going to go over very well.
>
> Jerry
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I known the patch is premature but a NULL pointer and in a device
driver needs to be patched no matter what.
If some one reading this has the hardware , it would be great if they
can test this :).
Cheers Nick



More information about the Kernelnewbies mailing list