[PATCH] staging: Check for Null return of allocated skb in fw_download_code

Valdis.Kletnieks at vt.edu Valdis.Kletnieks at vt.edu
Wed Aug 13 12:02:36 EDT 2014


On Wed, 13 Aug 2014 18:50:43 +0400, Max Filippov said:

> No need to trigger it, faking it would be enough, e.g.:

> +                if (++i < 3)
> +                        skb  = dev_alloc_skb(frag_length + 4);
> +                else
> +                        skb = NULL;

Don't bet on this triggering on a real system without some additional
scaffolding - take a look at what the function is doing, and ask yourself
how many times it will be called on the average system :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140813/645e13da/attachment.bin 


More information about the Kernelnewbies mailing list