some weird redundancy with a workqueue?

[Sannu K]

On Fri, Oct 19, 2012 at 6:42 PM, Robert P. J. Day <rpjday at crashcourse.ca> wrote:
>
>   is there something i'm missing about the following snippet of code
> in drivers/acpi/osl.c?
>
>         if (queue == kacpi_hotplug_wq)
>                 INIT_WORK(&dpc->work, acpi_os_execute_deferred);
>         else if (queue == kacpi_notify_wq)
>                 INIT_WORK(&dpc->work, acpi_os_execute_deferred);
>         else
>                 INIT_WORK(&dpc->work, acpi_os_execute_deferred);
>
> does anyone else find that code a bit ... odd?
>
> rday
>
> --
>
> ========================================================================
> Robert P. J. Day                                 Ottawa, Ontario, CANADA
>                         http://crashcourse.ca
>
> Twitter:                                       http://twitter.com/rpjday
> LinkedIn:                               http://ca.linkedin.com/in/rpjday
> ========================================================================
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Yes it really looks odd. This should have been caught in code review
before merging into mainline kernel code. I also doubt if I miss
something as it got merged and lives in kernel.

Thanks and Regards,
Sannu K