SYSLOG_ACTION_READ_ALL question

[William Douglas]

Hello all,

I'm trying to figure out why the do_syslog code in kernel/printk.c is using put_user instead of copy_to_user.

There is even a comment about how because of sleep, the buffer is read from back to front to minimize the impact of printk overwriting the syslog section we are using.  That wouldn't be necessary if a temporary copy was made and then written out with copy_to_user.

Does that make sense or am I missing something?


Thanks,
William