On Sat, Jul 12, 2014 at 11:29:37AM -0700, Joe Perches wrote:

On Sat, 2014-07-12 at 10:55 -0700, Greg KH wrote:

...

Yes, the warnings are all due to line-length, but Joe, you shouldn't add a patch that causes more checkpatch warnings than before :)

Yeah, that was intentional though.

This script does a series of relatively discrete changes.

Lindent would more or less work, but it's _horrible_ at wrapping overlong lines and merges all types of changes together.

Oh I agree, I don't want to see Lindent, but maybe, if the patch adds checkpatch warnings, it should be at least "flagged" as maybe a problem?

...

While I always want to see more developers get involved with kernel development, there should be a minimum barrier to entry. And that barrier is the knowledge of the C language, and knowledge of how to edit a text file, and use git. This script takes that barrier away, for whitespace cleanups, with not much real use overall.

So, I'll keep my local copy of this script now, just to have fun with at times when I'm bored. But I don't think it should be merged, as-is.

Dunno, I still think it's useful.

For you, and me, but the world? Would you want to be on the receiving end of this patch script? I don't, and I'm willing to take almost any patch cleanup for staging code. I think that says something :)

Maybe when you get new code, you might run it through a script like this before committing it.

I will keep it for me, like I said. thanks, greg k-h