Checkpatch.pl FAIL: "Blob or Tree named 'other' not found"
Hi all, I am trying to run checkpatch.pl on latest kernel version 5.1.0 source tree from orig head 80f232121b69cc69a31ccb2b38c1665d770b0710 When I run checkpatch.pl, for every file I get the follwong or similar error. Could you please help if this is my environment issue or actually error in code which I need to fix ? I executed the following in command prompt. perl scripts/checkpatch.pl -f drivers/staging/rtl8712/* |less The error I observe drivers/staging/rtl8712/rtl871x_rf.h ------------------------------------ FAIL: "Blob or Tree named 'other' not found" Traceback (most recent call last): File "scripts/spdxcheck.py", line 240, in <module> spdx = read_spdxdata(repo) File "scripts/spdxcheck.py", line 41, in read_spdxdata for el in lictree[d].traverse(): File "/usr/lib/python2.7/dist-packages/git/objects/tree.py", line 298, in __getitem__ return self.join(item) File "/usr/lib/python2.7/dist-packages/git/objects/tree.py", line 244, in join raise KeyError(msg % file) KeyError: "Blob or Tree named 'other' not found" total: 0 errors, 0 warnings, 0 checks, 56 lines checked Please suggest me. Best Regards Mishradk
On Sun, 12 May 2019 11:45:24 +0530, Deepak Mishra said:
When I run checkpatch.pl, for every file I get the follwong or similar error. Could you please help if this is my environment issue or actually error in code which I need to fix ?
I executed the following in command prompt. perl scripts/checkpatch.pl -f drivers/staging/rtl8712/* |less
The error I observe drivers/staging/rtl8712/rtl871x_rf.h
Found the problem, patch submitted. It's a one-line fix: diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py index 4fe392e507fb..7abd5f5cb14d 100755 --- a/scripts/spdxcheck.py +++ b/scripts/spdxcheck.py @@ -32,7 +32,7 @@ import os def read_spdxdata(repo): # The subdirectories of LICENSES in the kernel source - license_dirs = [ "preferred", "other", "exceptions" ] + license_dirs = [ "preferred", "dual", "deprecated", "exceptions" ] lictree = repo.head.commit.tree['LICENSES']
Thanks Valdis, After applying the patch, I verified in my environment and the patch has fixed the issue. Best Regards MishraDk On Sun, May 12, 2019 at 1:12 PM Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
On Sun, 12 May 2019 11:45:24 +0530, Deepak Mishra said:
When I run checkpatch.pl, for every file I get the follwong or similar error. Could you please help if this is my environment issue or actually error in code which I need to fix ?
I executed the following in command prompt. perl scripts/checkpatch.pl -f drivers/staging/rtl8712/* |less
The error I observe drivers/staging/rtl8712/rtl871x_rf.h
Found the problem, patch submitted. It's a one-line fix:
diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py index 4fe392e507fb..7abd5f5cb14d 100755 --- a/scripts/spdxcheck.py +++ b/scripts/spdxcheck.py @@ -32,7 +32,7 @@ import os def read_spdxdata(repo):
# The subdirectories of LICENSES in the kernel source - license_dirs = [ "preferred", "other", "exceptions" ] + license_dirs = [ "preferred", "dual", "deprecated", "exceptions" ] lictree = repo.head.commit.tree['LICENSES']
participants (2)
-
Deepak Mishra -
Valdis Klētnieks