Re: [Cocci] linux-kernel janitorial RFP: Mark static arrays as const
On Tue, 2 Mar 2021, Bernd Petrovitsch wrote:
Hi all!
On 02/03/2021 18:42, Joe Perches wrote: [...]
------------- For instance: (head -10 of the git grep for file statics)
drivers/accessibility/speakup/keyhelp.c:18:static u_short masks[] = { 32, 16, 8, 4, 2, 1 }; drivers/accessibility/speakup/keyhelp.c:26:static u_char funcvals[] = { drivers/accessibility/speakup/main.c:2059:static spkup_hand spkup_handler[] = { drivers/accessibility/speakup/speakup_acntpc.c:35:static unsigned int synth_portlist[] = { 0x2a8, 0 }; drivers/accessibility/speakup/speakup_decpc.c:133:static int synth_portlist[] = { 0x340, 0x350, 0x240, 0x250, 0 }; drivers/accessibility/speakup/speakup_dectlk.c:110:static int ap_defaults[] = {122, 89, 155, 110, 208, 240, 200, 106, 306}; drivers/accessibility/speakup/speakup_dectlk.c:111:static int g5_defaults[] = {86, 81, 86, 84, 81, 80, 83, 83, 73}; drivers/accessibility/speakup/speakup_dtlk.c:34:static unsigned int synth_portlist[] = { drivers/accessibility/speakup/speakup_keypc.c:34:static unsigned int synth_portlist[] = { 0x2a8, 0 }; drivers/acpi/ac.c:137:static enum power_supply_property ac_props[] = {
For drivers/accessibility/speakup/keyhelp.c:18:static u_short masks[] = { 32, 16, 8, 4, 2, 1 };
Looking at the examples: Just s/^static /static const / in the lines reported by the grep's above and see if it compiles (and save space)?
There is a small risk with compiling that there may be a problem for a configuration you haven't considered. julia
participants (1)
-
Julia Lawall