Re: [PATCH] MAINTAINERS: mark isapnp as obsolete
On Wed, Apr 28, 2021 at 02:17:00PM +0200, Jaroslav Kysela wrote:
Dne 28. 04. 21 v 13:11 Greg KH napsal(a):
On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote:
isapnp code is very old and according to this link https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications from Wikipedia, even Windows Vista disabled ISA PnP by default.
This change is in follow up to https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u
Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com>
Has the maintainer said this is unsupported?
I've no idea, if there're any users at the time, but there are many drivers which depend on this code.
IMHO, this is exactly "Odd fixes" - code not really dead, but not really alive too. Thanks
I'll try to reply to patch threads.
Jaroslav
-- Jaroslav Kysela <perex@perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
On 21/04/28 03:23PM, Leon Romanovsky wrote:
On Wed, Apr 28, 2021 at 02:17:00PM +0200, Jaroslav Kysela wrote:
Dne 28. 04. 21 v 13:11 Greg KH napsal(a):
On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote:
isapnp code is very old and according to this link https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications from Wikipedia, even Windows Vista disabled ISA PnP by default.
This change is in follow up to https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u
Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com>
Has the maintainer said this is unsupported?
I've no idea, if there're any users at the time, but there are many drivers which depend on this code.
IMHO, this is exactly "Odd fixes" - code not really dead, but not really alive too.
Okay! Does this have to come around as a v2 with 'Odd Fixes' instead of obsolete? Or should that be a separate patch? Or should we just wait for the maintainer's reply? Sorry i'm a little confused. thanks, karthik
Thanks
I'll try to reply to patch threads.
Jaroslav
-- Jaroslav Kysela <perex@perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
On Wed, Apr 28, 2021 at 2:32 PM B K Karthik <bkkarthik@pesu.pes.edu> wrote:
On 21/04/28 03:23PM, Leon Romanovsky wrote:
On Wed, Apr 28, 2021 at 02:17:00PM +0200, Jaroslav Kysela wrote:
Dne 28. 04. 21 v 13:11 Greg KH napsal(a):
On Wed, Apr 28, 2021 at 04:35:36PM +0530, Anupama K Patil wrote:
isapnp code is very old and according to this link https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications from Wikipedia, even Windows Vista disabled ISA PnP by default.
This change is in follow up to https://lore.kernel.org/lkml/20210422180322.7wlyg63kv3n2k6id@ubuntu/T/#u and https://lore.kernel.org/lkml/20210424194301.jmsqpycvsm7izbk3@ubuntu/T/#u
Suggested-by: B K Karthik <bkkarthik@pesu.pes.edu> Signed-off-by: Anupama K Patil <anupamakpatil123@gmail.com>
Has the maintainer said this is unsupported?
I've no idea, if there're any users at the time, but there are many drivers which depend on this code.
IMHO, this is exactly "Odd fixes" - code not really dead, but not really alive too.
Okay! Does this have to come around as a v2 with 'Odd Fixes' instead of obsolete? Or should that be a separate patch?
Or should we just wait for the maintainer's reply? Sorry i'm a little confused.
I don't think that the MAINTAINERS entry needs to be updated. Technically, this code is maintained, but because the availability of systems on which to test changes is kind of limited, intrusive functional changes in it should better be avoided. Thanks!
participants (3)
-
B K Karthik -
Leon Romanovsky -
Rafael J. Wysocki