Wait times for patch submission
Hi All, I wanted to check with ppl who frequently post patches to LKML on how long should one should wait before resending the patches in case there's no response to them. I had sent a patch on Greg KH's staging-next tree, on 16 Dec '14 to LKML and the relevant maintainers. I got a mail from Greg's friendly bot stating that the branch was closed and that the patches will be looked at once the merge window closes. Do I need to resend the patches again or will they be picked up from the maintainer's queue? Thanks, -mandeep
On Tue, Jan 06, 2015 at 11:31:53AM -0800, Mandeep Sandhu wrote:
Hi All,
I wanted to check with ppl who frequently post patches to LKML on how long should one should wait before resending the patches in case there's no response to them.
I had sent a patch on Greg KH's staging-next tree, on 16 Dec '14 to LKML and the relevant maintainers.
I got a mail from Greg's friendly bot stating that the branch was closed and that the patches will be looked at once the merge window closes.
And normally that would have happened already, but I was on vacation for a few weeks and am still catching up on patches. Stuff like code cleanup for staging is at the bottom of my list at the moment, as it's not essencial to get merged at the moment, only in time for the next release cycle.
Do I need to resend the patches again or will they be picked up from the maintainer's queue?
As you got an automated email from me already, all is fine, it's not lost, you will get another email when it is applied, or if there are problems with it. thanks, greg k-h
And normally that would have happened already, but I was on vacation for a few weeks and am still catching up on patches. Stuff like code cleanup for staging is at the bottom of my list at the moment, as it's not essencial to get merged at the moment, only in time for the next release cycle.
Sure, although this is not a cleanup patch. It's the UIO hotplug patch I bought to your attention a couple of weeks back. I'll wait for review comments on it once you and others get around to reviewing it. Thanks and a Happy new year to all! Regards, -mandeep
On Tue, Jan 06, 2015 at 01:24:33PM -0800, Mandeep Sandhu wrote:
And normally that would have happened already, but I was on vacation for a few weeks and am still catching up on patches. Stuff like code cleanup for staging is at the bottom of my list at the moment, as it's not essencial to get merged at the moment, only in time for the next release cycle.
Sure, although this is not a cleanup patch. It's the UIO hotplug patch I bought to your attention a couple of weeks back.
Ugh, that's going to require me to actually think when looking at that patch set, it might be a bit longer than a week or so :) thanks, greg k-h
Mandeep Sandhu <mandeepsandhu.chd@gmail.com> writes:
Hi All,
I wanted to check with ppl who frequently post patches to LKML on how long should one should wait before resending the patches in case there's no response to them.
That depends on lots of factors. Like how important the patch is, what kind of patch management system the maintainer uses, etc, etc.
I had sent a patch on Greg KH's staging-next tree, on 16 Dec '14 to LKML and the relevant maintainers.
I got a mail from Greg's friendly bot stating that the branch was closed and that the patches will be looked at once the merge window closes.
Which usually (always?) is true. Note that "once the merge window closes" doesn't necessarily mean within days after -rc1. It might mean a few weeks if the maintainer is busy doing other stuff, like travelling etc. And maintainers are always busy :-) Some maintainers even have a life, which implies taking time off with their family at this time of the year. You should therefore give them a week or two extra slack. And no, this does not count as "no response". You got a reply giving a precise description of how your patches will be handled and what you need to do.
Do I need to resend the patches again or will they be picked up from the maintainer's queue?
They will most likely be picked up as promised, and you'll get another mail telling you which tree they were added to. I would wait until at least -rc5 in any case before considering a repost of something destined for the next release. That still leaves plenty of time before the next merge window opens. Bjørn
Thanks for your input. I'll keep it in mind for the future. -mandeep On Tue, Jan 6, 2015 at 12:29 PM, Bjørn Mork <bjorn@mork.no> wrote:
Mandeep Sandhu <mandeepsandhu.chd@gmail.com> writes:
Hi All,
I wanted to check with ppl who frequently post patches to LKML on how long should one should wait before resending the patches in case there's no response to them.
That depends on lots of factors. Like how important the patch is, what kind of patch management system the maintainer uses, etc, etc.
I had sent a patch on Greg KH's staging-next tree, on 16 Dec '14 to LKML and the relevant maintainers.
I got a mail from Greg's friendly bot stating that the branch was closed and that the patches will be looked at once the merge window closes.
Which usually (always?) is true. Note that "once the merge window closes" doesn't necessarily mean within days after -rc1. It might mean a few weeks if the maintainer is busy doing other stuff, like travelling etc. And maintainers are always busy :-)
Some maintainers even have a life, which implies taking time off with their family at this time of the year. You should therefore give them a week or two extra slack.
And no, this does not count as "no response". You got a reply giving a precise description of how your patches will be handled and what you need to do.
Do I need to resend the patches again or will they be picked up from the maintainer's queue?
They will most likely be picked up as promised, and you'll get another mail telling you which tree they were added to.
I would wait until at least -rc5 in any case before considering a repost of something destined for the next release. That still leaves plenty of time before the next merge window opens.
Bjørn
participants (3)
-
Bjørn Mork -
Greg KH -
Mandeep Sandhu