Re: [PATCH 2662/2662] Staging: android: Fix 80 character length
I have created one patch and already submitted. Now I have created another patch for another directory . What should be the subject of patch [Patch 2/2] or just [patch ] ??? On Fri, Sep 18, 2015 at 3:00 PM, punit vara <punitvara@gmail.com> wrote:
Thank you sir I will do the same If I would find any patch
On Fri, Sep 18, 2015 at 2:45 PM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
usually i will create the patch with git format-patch -1 to generate the last patch
On Fri, Sep 18, 2015 at 2:42 PM, punit vara <punitvara@gmail.com> wrote:
before changing the file I did git fetch and then git remote update .At that time all patches came automatically with update .Then I simply create patch with git format-patch master..my_local_branch 2662-...
That is why subject was like [2662/2662] .
On Fri, Sep 18, 2015 at 2:37 PM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
I will also do git fetch but numbers will not show. what command you gave to generate the patch?
On Fri, Sep 18, 2015 at 2:26 PM, punit vara <punitvara@gmail.com> wrote:
Sorry sir about that ..I have done git fetch so another 2661 patches fetched .that's why mistakenly it subject was like that.I again changed patch as you guide and send.Thank you for feedback sir
On Fri, Sep 18, 2015 at 1:52 PM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
On Fri, Sep 18, 2015 at 12:38:21PM +0530, Punit Vara wrote:
This patch is to the Kconfig file which fixes up lines which exceeded the standard 80 character limitation. This file also fixes up 3 warnings regarding paragraph.
Signed-off-by: Punit Vara <punitvara@gmail.com> ---
Your subject says 2662/2662. Then where are your 2661 earlier patches of the series? No, that is wrong. The numbers we use when we submit a series of patches. But for a single patch (1/1) numbers are not required and 2662 is definitely wrong.
regards sudip
-- Regards, Punit Vara 9033553488
-- Regards, Punit Vara 9033553488
-- Regards, Punit Vara 9033553488
-- Regards, Punit Vara 9033553488
On Fri, Sep 18, 2015 at 4:42 PM, punit vara <punitvara@gmail.com> wrote:
I have created one patch and already submitted. Now I have created another patch for another directory . What should be the subject of patch [Patch 2/2] or just [patch ] ???
If its different, keep it different ;) -- Regards, Karthik Nayak
participants (2)
-
Karthik Nayak -
punit vara