screening patch here before sending to devs
i am learning from guides like this https://kernelnewbies.org/FirstKernelPatch#FirstPatch i sent an earlier patch, but was told to skip the drivers/staging/media directory. is this an acceptable patch? is this message double-posting? it looks like my prior message shows up twice. thanks! To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,linux-staging@lists.linux.dev,linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: move { onto opening line of if Checkpatch flagged this as a fixable style error. Signed-off-by: Daniel Watson <ozzloy@gmail.com> --- drivers/staging/rtl8723bs/include/rtw_recv.h | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_recv.h b/drivers/staging/rtl8723bs/include/rtw_recv.h index 44f67103503ae..fef2fd0e8c84f 100644 --- a/drivers/staging/rtl8723bs/include/rtw_recv.h +++ b/drivers/staging/rtl8723bs/include/rtw_recv.h @@ -398,8 +398,7 @@ static inline u8 *recvframe_pull(union recv_frame *precvframe, signed int sz) precvframe->u.hdr.rx_data += sz; - if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) - { + if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) { precvframe->u.hdr.rx_data -= sz; return NULL; } @@ -425,8 +424,7 @@ static inline u8 *recvframe_put(union recv_frame *precvframe, signed int sz) precvframe->u.hdr.rx_tail += sz; - if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) - { + if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) { precvframe->u.hdr.rx_tail = prev_rx_tail; return NULL; } @@ -451,8 +449,7 @@ static inline u8 *recvframe_pull_tail(union recv_frame *precvframe, signed int s precvframe->u.hdr.rx_tail -= sz; - if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) - { + if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) { precvframe->u.hdr.rx_tail += sz; return NULL; } -- 2.34.1
Hi Daniel, On Tue, Mar 28, 2023 at 6:29 AM Daniel Watson <ozzloy@gmail.com> wrote:
i am learning from guides like this https://kernelnewbies.org/FirstKernelPatch#FirstPatch
i sent an earlier patch, but was told to skip the drivers/staging/media directory.
is this an acceptable patch?
Generally, this is an acceptable patch. It might be that the patch is a bit too trivial to be picked up, but staging/rtl8723bs/ is probably a good place to start with trivial patches and have high chances for getting them picked up. Some minor nits below.
is this message double-posting? it looks like my prior message shows up twice.
Sometimes patches show up multiple times in lore.kernel.org archives, as some mailing list add further footers, so the same content sent is recorded slightly differently in the archives, leading to multiple copies. This is not considered double posting, though, as it is default to send a patch to multiple mailing lists, e.g., specific subsystem mailing list and the general linux-kernel mailing list. As long as the message has the same Message-ID, it is clear they were sent with one "git send-email" invocation.
thanks!
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,linux-staging@lists.linux.dev,linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: move { onto opening line of if
Usually "{" would be written out as "opening brackets" or as "curly brackets", just having a special character, like "{", is not seen often in commit message subject lines. Usually, consistency beats style. So, check if this pattern appears in any files in drivers/staging/rtl8723bs/ and its subdirectories and try to fix all instances within that directory with one patch. Other than that, it looks like a good newcomer's first submission patch. Lukas
Checkpatch flagged this as a fixable style error.
Signed-off-by: Daniel Watson <ozzloy@gmail.com> --- drivers/staging/rtl8723bs/include/rtw_recv.h | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_recv.h b/drivers/staging/rtl8723bs/include/rtw_recv.h index 44f67103503ae..fef2fd0e8c84f 100644 --- a/drivers/staging/rtl8723bs/include/rtw_recv.h +++ b/drivers/staging/rtl8723bs/include/rtw_recv.h @@ -398,8 +398,7 @@ static inline u8 *recvframe_pull(union recv_frame *precvframe, signed int sz)
precvframe->u.hdr.rx_data += sz;
- if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) - { + if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) { precvframe->u.hdr.rx_data -= sz; return NULL; } @@ -425,8 +424,7 @@ static inline u8 *recvframe_put(union recv_frame *precvframe, signed int sz)
precvframe->u.hdr.rx_tail += sz;
- if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) - { + if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) { precvframe->u.hdr.rx_tail = prev_rx_tail; return NULL; } @@ -451,8 +449,7 @@ static inline u8 *recvframe_pull_tail(union recv_frame *precvframe, signed int s
precvframe->u.hdr.rx_tail -= sz;
- if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) - { + if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) { precvframe->u.hdr.rx_tail += sz; return NULL; } -- 2.34.1
_______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
On Tue, Mar 28, 2023 at 09:03:17AM +0200, Lukas Bulwahn wrote:
Hi Daniel, Hi! thanks for pre-reviewing!
Sometimes patches show up multiple times in lore.kernel.org archives, as some mailing list add further footers, so the same content sent is recorded slightly differently in the archives, leading to multiple copies. This is not considered double posting, though, as it is default to send a patch to multiple mailing lists, e.g., specific subsystem mailing list and the general linux-kernel mailing list. As long as the message has the same Message-ID, it is clear they were sent with one "git send-email" invocation. cool. must be something wrong with gmail then. it's showing twice in my gmail. i'm not using git send-email, i'm using mutt configured to send through gmail.
Usually "{" would be written out as "opening brackets" or as "curly brackets", just having a special character, like "{", is not seen often in commit message subject lines. noted, i've changed that.
Usually, consistency beats style. So, check if this pattern appears in any files in drivers/staging/rtl8723bs/ and its subdirectories and try to fix all instances within that directory with one patch. earlier in the same file, the curly bracket appears on the opening line, except for functions.
Other than that, it looks like a good newcomer's first submission patch. that's great! i've sent it in with the changes.
i would like to work on my laptop battery's charge threshold. it can be changed in the bios, but not while running. there's a project for doing this on some thinkpads, but not the framework laptop. any pointers for where to get more info about this would be greatly appreciated. thanks again!
On Tue, Mar 28, 2023 at 12:47:26AM -0700, Daniel Watson wrote:
i would like to work on my laptop battery's charge threshold. it can be changed in the bios, but not while running. there's a project for doing this on some thinkpads, but not the framework laptop. any pointers for where to get more info about this would be greatly appreciated.
Are you sure that it is even possible to change this from the operating system while the system is running? It might be restricted only to the BIOS settings. thanks, greg k-h
On Tue, Mar 28, 2023 at 09:57:52AM +0200, Greg KH wrote:
Are you sure that it is even possible to change this from the operating system while the system is running? It might be restricted only to the BIOS settings.
it is possible! it has already been done. https://lkml.org/lkml/2022/1/4/1160
that's exciting! that means i can read it to see what is involved. thanks for prompting me to check on whether it was possible.
participants (3)
-
Daniel Watson -
Greg KH -
Lukas Bulwahn