Fwd: How to avoid volatiles
Forwarding to kernelnewbies list.. ---------- Forwarded message ---------- From: Prabhakar Lad <prabhakar.csengg@gmail.com> Date: Fri, Oct 14, 2011 at 3:35 PM Subject: Re: How to avoid volatiles To: Srivatsa Bhat <bhat.srivatsa@gmail.com> Hi, here you go Patch <http://patchwork.ozlabs.org/patch/115134/> Regards --Prabhakar On Fri, Oct 14, 2011 at 3:33 PM, Srivatsa Bhat <bhat.srivatsa@gmail.com>wrote:
On Fri, Oct 14, 2011 at 3:27 PM, Prabhakar Lad <prabhakar.csengg@gmail.com
wrote:
Hi Srivatsa,
I had a patch to submit but because of this issue its not being accepted.
Regards --Prabhakar
Hi Prabhakar,
Can you give a pointer (link) to your patch?
Regards, Srivatsa S. Bhat
On Fri, Oct 14, 2011 at 3:39 PM, Srivatsa Bhat <bhat.srivatsa@gmail.com>wrote:
Forwarding to kernelnewbies list..
---------- Forwarded message ---------- From: Prabhakar Lad <prabhakar.csengg@gmail.com> Date: Fri, Oct 14, 2011 at 3:35 PM Subject: Re: How to avoid volatiles To: Srivatsa Bhat <bhat.srivatsa@gmail.com>
Hi,
here you go Patch <http://patchwork.ozlabs.org/patch/115134/>
Regards --Prabhakar
Hmm.. from what I see, the warnings are due to use of volatile keyword, but the code already existed in the kernel and you just moved it to another file.. Regards, Srivatsa S. Bhat
Hi, Yes even though its a movement checkpatch doesn't consider it ;) . Regards --Prabhakar On Fri, Oct 14, 2011 at 3:49 PM, Srivatsa Bhat <bhat.srivatsa@gmail.com>wrote:
On Fri, Oct 14, 2011 at 3:39 PM, Srivatsa Bhat <bhat.srivatsa@gmail.com>wrote:
Forwarding to kernelnewbies list..
---------- Forwarded message ---------- From: Prabhakar Lad <prabhakar.csengg@gmail.com> Date: Fri, Oct 14, 2011 at 3:35 PM Subject: Re: How to avoid volatiles To: Srivatsa Bhat <bhat.srivatsa@gmail.com>
Hi,
here you go Patch <http://patchwork.ozlabs.org/patch/115134/>
Regards --Prabhakar
Hmm.. from what I see, the warnings are due to use of volatile keyword, but the code already existed in the kernel and you just moved it to another file..
Regards, Srivatsa S. Bhat
On Fri, Oct 14, 2011 at 3:51 PM, Prabhakar Lad <prabhakar.csengg@gmail.com>wrote:
Hi,
Yes even though its a movement checkpatch doesn't consider it ;) .
Thats good in a way because, that way existing bad code will get fixed (even if forcefully) :)
Regards, Srivatsa S. Bhat
participants (2)
-
Prabhakar Lad -
Srivatsa Bhat