Hi Anish<br><br><br><br><div class="gmail_quote">On Mon, Feb 28, 2011 at 5:53 PM, anish singh <span dir="ltr">&lt;<a href="mailto:anish198519851985@gmail.com">anish198519851985@gmail.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>I have a touch driver which is not yet using threded_irq.So i am planning to change it to</div>
<div>use threaded_irq.</div>
<div> </div>
<div>In the current handler they are first disabling the irq line and then calling the single threaded</div>
<div>workqueue to do the rest of the task and when the task is completed i.e. in the end of workqueue</div>
<div>function they are enabling the irq line.<br> </div>
<div></div></blockquote><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div> </div>
<div>So my question is if i change it to use threaded_irq.In the handler should i also enable or disable</div>
<div>the irq as is done in the case of present handler OR i don&#39;t need to do this step?</div>
<div>---i think IRQF_ONESHOT will do this for me right?</div></blockquote><div><br>There could be a very good reason, why IRQ were disabled at entry and re-enabled at exit in workqueue.  <br>For example if, workqueue  is acquiring the spinlock and which is expected to be acquired by ISR  also.<br>
Probably you should reason why irq were disabled/enabled in work queue and redesign your threded_irq accordingly<br><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

<div> </div>
<div>I want this threaded handler to be executing as soon as possible as i want the latency between the</div>
<div>touch by the user and response to be minimum.Is there any way to achieve this?</div>
<div> </div>
<div>FYI... handler contains some I2C transfer + reporting co-ordinates to Input core.</div>
<div> </div>
<div>Does the above usecase justify changing to threaded_irq??</div>
<div><br> </div>
<div> </div>
<br></blockquote><div><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">_______________________________________________<br>
Kernelnewbies mailing list<br>
<a href="mailto:Kernelnewbies@kernelnewbies.org">Kernelnewbies@kernelnewbies.org</a><br>
<a href="http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies" target="_blank">http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies</a><br>
<br></blockquote></div><br><br>Regards<br>Spinlock<br>