NBEMS (fldigi et. all) updates
Just reaching out to see who all uses the NBEMS suite of programs, specifically fldigi, flrig, and flmsg. Over the last month I have taken up trying to learn C/C++ and decided to use Dave's suite of programs to cut my teeth on. I've "fixed" a number of things in the three above programs but they haven't been included in a release... yet. Some of them are important enough I've been applying them a patches to the current Fedora builds. Here's a summary log of my changes: fldigi: (mostly compiler warnings and MinGW fixes) 77ac39e8 Comment out memset in fsq.cxx and other type fixes. 87b3c9d1 Cast to int from trx_mode (intptr_t) with LOG_ statement. 4b49672c Require use of system regex. 70ab21ae MinGW updates: aff671cf Can't pass by reference as it may change (or not be valid) by the time it's executed. f7dd4994 For rigCAT_update_pwrlevel, change from void to long for consistance (since type is known) and pass by reference instead of pointer since we're dealing with C++ fcc7996a Bring in needed files from tmp/mingw for nsis packaging. 470e062f Additional fixes for MinGW 64bit. e00075b6 Fix warning about boundary. 3acdfaa1 Fix warning about boundary issue. flrig: 7e9e2e4 FT-991A.cxx: get/set split fixes: 73bb797 Formatting cleanup on FT991. db36b7d FT-991A mic gain values are 0 .. 100. 3e9735e FT-450D Mic Gain fixes 2a293ca cppcheck: XmlRpc f84304f Remove superfluous ceil call in get_rf_gain() as the cast to int truncates it anyway. 7744166 Tweaks for Yaesu FT-450D and Kenwood TS-480SAT flmsg: c2e2b50 Add check in function arqlog for when nom is not empty bus s is. - This one fixes a crash when pressing the "Send" button. eed58aa cppcheck: fix memory leaks src/utils/status.cxx. d1e479f cppcheck: fix memory leaks in src/utils/parse_xml.cxx. bede427 cppcheck: fix memory leaks in src/transfer/transfer.cxx. 0da8b1a cppcheck: fix memory leaks in src/flmsg.cxx. 745da0f cppcheck: fix memory leaks in src/custom/custom.cxx. f971885 cppcheck: fix memory leaks in csv.cxx. Thanks, Richard KF5OIM
On Wed, 2020-07-29 at 08:13 -0500, Richard Shaw wrote:
Just reaching out to see who all uses the NBEMS suite of programs, specifically fldigi, flrig, and flmsg.
I use fldigi all the time. I usually just send my changes directly to Dave, though. He tends to pick them up within a few days, and they'll be in the next fldigi release, which also happens quickly most of the time. I have found Dave to be a very easy to work with upstream maintainer.
Over the last month I have taken up trying to learn C/C++ and decided to use Dave's suite of programs to cut my teeth on. I've "fixed" a number of things in the three above programs but they haven't been included in a release... yet.
Some of them are important enough I've been applying them a patches to the current Fedora builds.
Here's a summary log of my changes:
fldigi: (mostly compiler warnings and MinGW fixes) 77ac39e8 Comment out memset in fsq.cxx and other type fixes. 87b3c9d1 Cast to int from trx_mode (intptr_t) with LOG_ statement. 4b49672c Require use of system regex. 70ab21ae MinGW updates: aff671cf Can't pass by reference as it may change (or not be valid) by the time it's executed. f7dd4994 For rigCAT_update_pwrlevel, change from void to long for consistance (since type is known) and pass by reference instead of pointer since we're dealing with C++ fcc7996a Bring in needed files from tmp/mingw for nsis packaging. 470e062f Additional fixes for MinGW 64bit. e00075b6 Fix warning about boundary. 3acdfaa1 Fix warning about boundary issue.
flrig: 7e9e2e4 FT-991A.cxx: get/set split fixes: 73bb797 Formatting cleanup on FT991. db36b7d FT-991A mic gain values are 0 .. 100. 3e9735e FT-450D Mic Gain fixes 2a293ca cppcheck: XmlRpc f84304f Remove superfluous ceil call in get_rf_gain() as the cast to int truncates it anyway. 7744166 Tweaks for Yaesu FT-450D and Kenwood TS-480SAT
flmsg: c2e2b50 Add check in function arqlog for when nom is not empty bus s is. - This one fixes a crash when pressing the "Send" button. eed58aa cppcheck: fix memory leaks src/utils/status.cxx. d1e479f cppcheck: fix memory leaks in src/utils/parse_xml.cxx. bede427 cppcheck: fix memory leaks in src/transfer/transfer.cxx. 0da8b1a cppcheck: fix memory leaks in src/flmsg.cxx. 745da0f cppcheck: fix memory leaks in src/custom/custom.cxx. f971885 cppcheck: fix memory leaks in csv.cxx.
Thanks, Richard KF5OIM _______________________________________________ Fedora-hams mailing list Fedora-hams@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/fedora-hams -- All Rights Reversed.
On Wed, Jul 29, 2020 at 8:26 AM Rik van Riel <riel@surriel.com> wrote:
On Wed, 2020-07-29 at 08:13 -0500, Richard Shaw wrote:
Just reaching out to see who all uses the NBEMS suite of programs, specifically fldigi, flrig, and flmsg.
I use fldigi all the time.
I usually just send my changes directly to Dave, though. He tends to pick them up within a few days, and they'll be in the next fldigi release, which also happens quickly most of the time.
Yup, absolutely, I've just hit him with a ton of commits though :) Thanks, Richard
I run fldigi and flrig from the Fedora repos, so I appreciate your efforts. I still need to set up the full suite. I'll take a look at the ft-450d fixes. I have a fairly reproducible crash in flrig with the ft-450 I need to chase down, so this was a good reminder. mike, kj6vcp
On Thu, Jul 30, 2020 at 8:07 AM Michael Pittaro <mikeyp@lhrc.com> wrote:
I run fldigi and flrig from the Fedora repos, so I appreciate your efforts. I still need to set up the full suite.
I'll take a look at the ft-450d fixes. I have a fairly reproducible crash in flrig with the ft-450 I need to chase down, so this was a good reminder.
At this point my updates have made it into testing, but not stable, but braver souls can use my COPR[1] so you'll get the updates as soon as they're built. Thanks, Richard [1] https://copr.fedorainfracloud.org/coprs/hobbes1069/NBEMS/
I was planning to start using fldigi unless there is a better recommendation. On 7/29/20 6:13 AM, Richard Shaw wrote:
Just reaching out to see who all uses the NBEMS suite of programs, specifically fldigi, flrig, and flmsg.
Over the last month I have taken up trying to learn C/C++ and decided to use Dave's suite of programs to cut my teeth on. I've "fixed" a number of things in the three above programs but they haven't been included in a release... yet.
Some of them are important enough I've been applying them a patches to the current Fedora builds.
Here's a summary log of my changes:
fldigi: (mostly compiler warnings and MinGW fixes) 77ac39e8 Comment out memset in fsq.cxx and other type fixes. 87b3c9d1 Cast to int from trx_mode (intptr_t) with LOG_ statement. 4b49672c Require use of system regex. 70ab21ae MinGW updates: aff671cf Can't pass by reference as it may change (or not be valid) by the time it's executed. f7dd4994 For rigCAT_update_pwrlevel, change from void to long for consistance (since type is known) and pass by reference instead of pointer since we're dealing with C++ fcc7996a Bring in needed files from tmp/mingw for nsis packaging. 470e062f Additional fixes for MinGW 64bit. e00075b6 Fix warning about boundary. 3acdfaa1 Fix warning about boundary issue.
flrig: 7e9e2e4 FT-991A.cxx: get/set split fixes: 73bb797 Formatting cleanup on FT991. db36b7d FT-991A mic gain values are 0 .. 100. 3e9735e FT-450D Mic Gain fixes 2a293ca cppcheck: XmlRpc f84304f Remove superfluous ceil call in get_rf_gain() as the cast to int truncates it anyway. 7744166 Tweaks for Yaesu FT-450D and Kenwood TS-480SAT
flmsg: c2e2b50 Add check in function arqlog for when nom is not empty bus s is. - This one fixes a crash when pressing the "Send" button. eed58aa cppcheck: fix memory leaks src/utils/status.cxx. d1e479f cppcheck: fix memory leaks in src/utils/parse_xml.cxx. bede427 cppcheck: fix memory leaks in src/transfer/transfer.cxx. 0da8b1a cppcheck: fix memory leaks in src/flmsg.cxx. 745da0f cppcheck: fix memory leaks in src/custom/custom.cxx. f971885 cppcheck: fix memory leaks in csv.cxx.
Thanks, Richard KF5OIM
_______________________________________________ Fedora-hams mailing list Fedora-hams@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/fedora-hams
On Sun, Aug 2, 2020 at 6:48 PM Jerry DeLisle <jvdelisle@charter.net> wrote:
I was planning to start using fldigi unless there is a better recommendation.
Depends on what you want to do, but there's not really anything that provides the same level of functionality and number of modes. Thanks, Richard
participants (4)
-
Jerry DeLisle -
Michael Pittaro -
Richard Shaw -
Rik van Riel