<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head><meta content="text/html;charset=UTF-8" http-equiv="Content-Type"></head><body ><div dir='auto' style='font-size:10pt;font-family:Verdana,Arial,Helvetica,sans-serif;'><div id="message" dir="auto"><div dir="auto" style="font-size:10pt;font-family:Verdana,Arial,Helvetica,sans-serif;"><div id="message" dir="auto"><div>---- Fri, 25 Jul 2025 18:12:14 +0530 को rakagunarto@gmail.com ने लिखा ----</div></div><div id="content" dir="auto"><div><mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]>> - Clarity to readers that the pointer is guaranteed to be non-null,</mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]></div><div><mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]><br></mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]></div><div>Assumption isn't a guarantee.</div><div><mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]><br></mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]></div><div><mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]>> and that a check is redundant (because performance critical context,<br>> etc.)</mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]></div><div><mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]><br></mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]></div><div><mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]>Compiler optimises it away usually.</mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]></div><div><mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]><br>> - Future patches that decide to use this macro can be a signal to<br>> reviewers to actually check correctness that a pointer is indeed<br>> invariably non-null</mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]></div><div><br></div><div dir="auto">That can pretty easily change in future.</div><div dir="auto"><br></div><div><mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]>> - Make static analysis more useful by documenting when a certain false<br>> positive is actually false</mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]></div><div><br></div><div>Is your case really a false positive?</div><div dir="auto"><br></div><div><mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]>There is an explicit check for NULL in some other using the</mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]></div><div><mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]>get_node function, </mulyadi.santosa@gmail.com[mailto:mulyadi.santosa@gmail.com]><span style="font-size: 10pt;">most visibly in the macro below.</span></div><div><span style="font-size: 10pt;"><br></span></div><div><span style="font-size: 10pt;">If we know NULL won't be there, we should add an</span></div><div><span style="font-size: 10pt;">assert in code instead of a silent assumption.</span></div><div><span style="font-size: 10pt;"><br></span></div><div><span style="font-size: 10pt;">Thanks,</span></div><div><span style="font-size: 10pt;">Siddh</span></div></div></div></div><div id="signature" dir="auto"></div><div id="content" dir="auto"></div></div><br></body></html>