<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr"><meta http-equiv="content-type" content="text/html; charset=utf-8"><div dir="ltr"><meta http-equiv="content-type" content="text/html; charset=utf-8">Hi all,</div><div dir="ltr"><div dir="ltr"><br></div><div dir="ltr">I am an embedded software engineer. I use Linux every day, and I appreciate its neatness and simplicity.</div><div dir="ltr"><br></div><div dir="ltr">One day, I watched a video from Greg: <a href="https://youtu.be/LLBrBBImJt4">https://youtu.be/LLBrBBImJt4</a>, and I started wondering if maybe I could contribute to the Linux kernel. So, I sent a very simple (and maybe stupid) patch to the community:</div><div dir="ltr"><br></div><div><div><blockquote type="cite" __apple_fixed_attribute="true" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">On Fri, Aug 30, 2024 at 04:54:38PM +0800, Qianqiang Liu wrote:<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">There is no need to add parentheses around 'devcode != 0x0000' and<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">'devcode != 0x9320'<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;"><br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">Signed-off-by: Qianqiang Liu <<span dir="ltr">qianqiang.liu@163.com</span>><br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">---<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">drivers/staging/fbtft/fb_ili9320.c | 2 +-<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">1 file changed, 1 insertion(+), 1 deletion(-)<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;"><br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">index 0be7c2d51548..409b54cc562e 100644<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">--- a/drivers/staging/fbtft/fb_ili9320.c<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">+++ b/drivers/staging/fbtft/fb_ili9320.c<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">@@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par)<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;"> devcode = read_devicecode(par);<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;"> fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n",<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;"> devcode);<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">- if ((devcode != 0x0000) && (devcode != 0x9320))<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">+ if (devcode != 0x0000 && devcode != 0x9320)<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;"> dev_warn(par->info->device,<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;"> "Unrecognized Device code: 0x%04X (expected 0x9320)\n",<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;"> devcode);<br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">-- <br></blockquote><blockquote type="cite" style="color: rgb(0, 0, 0); -webkit-text-size-adjust: auto;">2.39.2</blockquote></div><div><div><br></div><div>It turns out that the patch was rejected.</div><div><br></div><div>So, my question is: how can I start contributing to the Linux kernel? Maybe I could start by fixing some small bugs?</div></div><div><br></div><div><div dir="ltr">Thanks,<div>Qianqiang Liu</div></div></div></div></div></div></body></html>