<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 7, 2017 at 11:20 PM, Tobin C. Harding <span dir="ltr"><<a href="mailto:me@tobin.cc" target="_blank">me@tobin.cc</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Question relating to the validity/usefulness of patching calls to sizeof.<br>
<br>
>From Documentation/process/coding-<wbr>style.rst<br>
<br>
The preferred form for passing a size of a struct is the following:<br>
<br>
.. code-block:: c<br>
<br>
p = kmalloc(sizeof(*p), ...);<br>
<br>
The alternative form where struct name is spelled out hurts readability and<br>
introduces an opportunity for a bug when the pointer variable type is changed<br>
but the corresponding sizeof that is passed to a memory allocator is not.Is the distinction between<br>
<br>
<br>
Question:<br>
<br>
Is a the following a valid/useful patch or just code churn<br>
<br>
diff--<br>
<br>
- sizeof(struct foo)<br>
+ sizeof(*fp)<br>
<br></blockquote><div><br></div><div>That should depend on consistency of convention in whole file. If there are multiple instance of this in same file(or whole module), it might not make sense to change them all.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
<br>
______________________________<wbr>_________________<br>
Kernelnewbies mailing list<br>
<a href="mailto:Kernelnewbies@kernelnewbies.org">Kernelnewbies@kernelnewbies.<wbr>org</a><br>
<a href="https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies" rel="noreferrer" target="_blank">https://lists.kernelnewbies.<wbr>org/mailman/listinfo/<wbr>kernelnewbies</a><br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Thank you <br>Warm Regards<br>Anuz<br></div>
</div></div>