<p dir="ltr">Hi,</p>
<p dir="ltr">Thank you for your reply. <br>
I'll follow your suggestion.</p>
<br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 30, 2016, 11:19 AM Bjørn Mork <<a href="mailto:bjorn@mork.no">bjorn@mork.no</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Amit Kumar <<a href="mailto:free.amit.kumar@gmail.com" target="_blank">free.amit.kumar@gmail.com</a>> writes:<br>
<br>
> Signed-off-by: Amit Kumar <<a href="mailto:free.amit.kumar@gmail.com" target="_blank">free.amit.kumar@gmail.com</a>><br>
><br>
> This is a test patch.<br>
> Is this patch in right format?<br>
> ---<br>
> Documentation/initest.txt | 7 +++++++<br>
> 1 file changed, 7 insertions(+)<br>
> create mode 100644 Documentation/initest.txt<br>
><br>
> diff --git a/Documentation/initest.txt b/Documentation/initest.txt<br>
> new file mode 100644<br>
> index 0000000..eed4124<br>
> --- /dev/null<br>
> +++ b/Documentation/initest.txt<br>
> @@ -0,0 +1,7 @@<br>
> +INITEST<br>
> +<br>
> +1) This is the same user space program /sbin/init, but for the purpose of testing kernel system calls.<br>
> +<br>
> +2) It will also use testing drivers to test internal kernel API.<br>
> +<br>
> +3) This is a test patch.<br>
<br>
<br>
Looks pretty good. But a few more things to keep in mind:<br>
<br>
1) There should be *some* body text describing the patch, even for a very<br>
basic change which is explained in full in subject. This goes first<br>
in the body, separated from the tags with a single empty line.<br>
<br>
2) Signed-off-by and other tags go at the end of the body, right before<br>
the "---" separator. Don't put anything between the SOB and the<br>
separator. I realize that this was just a question that you wouldn't<br>
make part of the submitted patch but still: It broke your example...<br>
<br>
3) There is a place for questions about the patch which you do not want<br>
to be part of the commit message: Right After the first "---"<br>
separator. Anything yout put there will be ignored by git when the<br>
patch is applied, just like the diffstat git includes by itself.<br>
<br>
This is useful if you need to explain something to the maintainer<br>
regarding how to apply the patch, or if ytou have questions about it<br>
which are irrelevant if applied.<br>
<br>
<br>
<br>
So the end result would be:<br>
<br>
<br>
Subject: [PATCH] INITEST: Documentation: Explains how INITEST works.<br>
<br>
This is a test patch.<br>
<br>
Signed-off-by: Amit Kumar <<a href="mailto:free.amit.kumar@gmail.com" target="_blank">free.amit.kumar@gmail.com</a>><br>
---<br>
Is this patch in right format?<br>
<br>
<br>
Documentation/initest.txt | 7 +++++++<br>
1 file changed, 7 insertions(+)<br>
create mode 100644 Documentation/initest.txt<br>
<br>
diff --git a/Documentation/initest.txt b/Documentation/initest.txt<br>
[etc]<br>
<br>
<br>
<br>
Bjørn<br>
</blockquote></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><p dir="ltr">Regards,<br>
Amit Kumar<br>
Twitter: @freeark1<br>
Only Numbers Can Command.</p>
</div>