<div dir="ltr">How does this version look?<div><br></div><div>(the other delta for the other file was untouched)<br><div><br></div><div>Any chance it is ready to post to the big list (presumably fs with a cc to lkml)?</div><div><br></div><div><div>diff --git a/fs/Kconfig b/fs/Kconfig</div><div>index 6ce72d8..122a993 100644</div><div>--- a/fs/Kconfig</div><div>+++ b/fs/Kconfig</div><div>@@ -4,6 +4,20 @@</div><div> </div><div> menu "File systems"</div><div> </div><div>+config DEFAULT_STRICTATIME</div><div>+<span class="" style="white-space:pre"> </span>bool "Use strictatime by default"</div><div>+<span class="" style="white-space:pre"> </span>default n</div><div>+<span class="" style="white-space:pre"> </span>help</div><div>+<span class="" style="white-space:pre"> </span> Use strictatime as a default mount option.</div><div>+</div><div>+<span class="" style="white-space:pre"> </span> Relatime became the default in 2007 to reduce I/O load on block devices.</div><div>+</div><div>+<span class="" style="white-space:pre"> </span> Enabling this option will restore historic behavior and provide perfectly</div><div>+<span class="" style="white-space:pre"> </span> accurate atimes, but the increase in write load may reduce performance</div><div>+<span class="" style="white-space:pre"> </span> and shorten the life of the block device.</div><div>+</div><div>+<span class="" style="white-space:pre"> </span> If unsure, say N.</div><div>+</div><div> # Use unaligned word dcache accesses</div><div> config DCACHE_WORD_ACCESS</div><div> bool</div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 18, 2015 at 2:21 PM, Mandeep Sandhu <span dir="ltr"><<a href="mailto:mandeepsandhu.chd@gmail.com" target="_blank">mandeepsandhu.chd@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ah yes...now it makes sense! :)<br>
<br>
The current 'word of caution' (about increased I/O load on block<br>
devices), seems mild IMHO. Maybe we should we have a stricter<br>
warning...something like enabling this option might be harmful to the<br>
life of your block device (due to excessive writes) and will also lead<br>
to reduced performance?<br>
<br>
HTH,<br>
-mandeep<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Fri, Dec 18, 2015 at 2:12 PM, Raymond Jennings <<a href="mailto:shentino@gmail.com">shentino@gmail.com</a>> wrote:<br>
> On Fri, Dec 18, 2015 at 10:50 AM, Mandeep Sandhu<br>
> <<a href="mailto:mandeepsandhu.chd@gmail.com">mandeepsandhu.chd@gmail.com</a>> wrote:<br>
>><br>
>> You've removed the strictatime option altogether. So how does that<br>
>> satisfy people who _do_ want it?<br>
><br>
><br>
> ...actually it looks like I was an idiot and got my diff backwards when I<br>
> pulled it out of git :P<br>
><br>
> Here's the correct version.<br>
><br>
> diff --git a/fs/Kconfig b/fs/Kconfig<br>
> index 6ce72d8..4b917eb 100644<br>
> --- a/fs/Kconfig<br>
> +++ b/fs/Kconfig<br>
> @@ -4,6 +4,17 @@<br>
><br>
> menu "File systems"<br>
><br>
> +config DEFAULT_STRICTATIME<br>
> + bool "Use strictatime by default"<br>
> + default n<br>
> + help<br>
> + Use strictatime as a default mount option.<br>
> +<br>
> + Strictatime preserves ancient historic behavior of keeping the<br>
> atime field always up to date.<br>
> + However, it was changed in 2007 to relatime to reduce I/O load on<br>
> block devices.<br>
> +<br>
> + If unsure, say N.<br>
> +<br>
> # Use unaligned word dcache accesses<br>
> config DCACHE_WORD_ACCESS<br>
> bool<br>
> diff --git a/fs/namespace.c b/fs/namespace.c<br>
> index 0570729..48e7c15 100644<br>
> --- a/fs/namespace.c<br>
> +++ b/fs/namespace.c<br>
> @@ -2680,9 +2680,15 @@ long do_mount(const char *dev_name, const char __user<br>
> *dir_name,<br>
> if (retval)<br>
> goto dput_out;<br>
><br>
> - /* Default to relatime unless overriden */<br>
> +#ifdef CONFIG_DEFAULT_STRICTATIME<br>
> + /* Default to strictatime unless overridden */<br>
> + if (flags & MS_RELATIME)<br>
> + mnt_flags |= MNT_RELATIME;<br>
> +#else<br>
> + /* Default to relatime unless overridden */<br>
> if (!(flags & MS_NOATIME))<br>
> mnt_flags |= MNT_RELATIME;<br>
> +#endif<br>
><br>
><br>
> /* Separate the per-mountpoint flags */<br>
> if (flags & MS_NOSUID)<br>
><br>
><br>
><br>
</div></div></blockquote></div><br></div>