<div dir="ltr">Hi,<div><br></div><div>Actually on the website it's return that </div><p style="margin:0.6em 1ex;padding:0px;color:rgb(0,0,0);font-size:12px;line-height:15px"><font face="arial, helvetica, sans-serif">Pick a warning, and try to fix it. For your first patch, only pick one warning. In the future you can group multiple changes into one patch, but only if you follow the <a href="http://kernelnewbies.org/PatchPhilosophy" style="border:0px;text-decoration:none;color:rgb(0,102,204);background-color:transparent">PatchPhilosophy</a> of breaking each patch into logical changes.</font></p><p style="margin:0.6em 1ex;padding:0px;color:rgb(0,0,0);font-size:12px;line-height:15px"><br></p><p style="margin:0.6em 1ex;padding:0px;color:rgb(0,0,0);font-size:12px;line-height:15px">That's hwy I just fix one warning. </p><p style="margin:0.6em 1ex;padding:0px;color:rgb(0,0,0);font-size:12px;line-height:15px"><br></p><p style="margin:0.6em 1ex;padding:0px;color:rgb(0,0,0);font-size:12px;line-height:15px">Please let me know if I can fix more than one warning in my first patch.</p><p style="margin:0.6em 1ex;padding:0px;color:rgb(0,0,0);font-size:12px;line-height:15px"><br></p><p style="margin:0.6em 1ex;padding:0px;color:rgb(0,0,0);font-size:12px;line-height:15px">Thanks,</p><p style="margin:0.6em 1ex;padding:0px;color:rgb(0,0,0);font-size:12px;line-height:15px">Shirish</p></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 8, 2015 at 12:32 PM, <span dir="ltr"><<a href="mailto:Valdis.Kletnieks@vt.edu" target="_blank">Valdis.Kletnieks@vt.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, 08 Jan 2015 12:00:07 -0800, shirish gajera said:<br>
<br>
> WARNING: Single statement macros should not use a do {} while (0) loop<br>
><br>
> I have added single statement in curly braces, because it was giving<br>
> me "WARNING: macros should not use a trailing semicolon".<br>
><br>
> Signed-off-by: Shirish Gajera <<a href="mailto:gajerashirish@gmail.com">gajerashirish@gmail.com</a>><br>
> ---<br>
> drivers/staging/skein/skein_block.c | 8 ++++----<br>
> 1 file changed, 4 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/drivers/staging/skein/skein_block.c<br>
> b/drivers/staging/skein/skein_block.c<br>
> index 66261ab..5f46cd6 100644<br>
> --- a/drivers/staging/skein/skein_block.c<br>
> +++ b/drivers/staging/skein/skein_block.c<br>
> @@ -82,10 +82,10 @@ do {<br>
> \<br>
> } while (0)<br>
> #else<br>
> /* looping version */<br>
> -#define R256(p0, p1, p2, p3, ROT, r_num) \<br>
<br>
</span>Why did you not fix the definition of R256 in the other half of<br>
the "#if SKEIN_UNROLL_256 == 0" code? Or the definitions for R512<br>
and R1024? You cleaned up one case, and left another 5 cases alone....<br>
<br>
(This is part of why blindly fixing checkpatch complaints without actually<br>
looking at the code and understanding isn't always a good thing)<br>
<br>
</blockquote></div><br></div>