Thanks for your input.<br><br><div class="gmail_quote">On Thu, Dec 18, 2014, 6:17 AM Greg KH <<a href="mailto:greg@kroah.com">greg@kroah.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Dec 17, 2014 at 04:24:15PM -0500, <a href="mailto:Valdis.Kletnieks@vt.edu" target="_blank">Valdis.Kletnieks@vt.edu</a> wrote:<br>
> On Wed, 17 Dec 2014 19:10:24 +0000, karthik nayak said:<br>
><br>
> > The only reason I didn't do that is cause the file is too large to<br>
> > manually have a look at, even the diff tends to be very huge.<br>
><br>
> [/usr/src/linux-next] grep '//' drivers/staging/rtl8192u/<u></u>r8192U_dm.c | wc -l<br>
> 373<br>
><br>
> And why use lex when sed is up to the task?<br>
><br>
> [/usr/src/linux-next] sed 's?//(.*)$?/* \1 */?' drivers/staging/rtl8192u/<u></u>r8192U_dm.c >| /tmp/z99<br>
> sed: -e expression #1, char 19: invalid reference \1 on `s' command's RHS<br>
> 1 [/usr/src/linux-next] sed 's?//\(.*\)$?/* \1 */?' drivers/staging/rtl8192u/<u></u>r8192U_dm.c >| /tmp/z99<br>
> 0 [/usr/src/linux-next] diff -u drivers/staging/rtl8192u/<u></u>r8192U_dm.c /tmp/z99 | head -20<br>
> --- drivers/staging/rtl8192u/<u></u>r8192U_dm.c 2014-11-20 16:18:35.941071156 -0500<br>
> +++ /tmp/z99 2014-12-17 16:22:42.831566630 -0500<br>
> @@ -21,9 +21,9 @@<br>
> #include "r8190_rtl8256.h"<br>
> #include "r819xU_cmdpkt.h"<br>
> /*---------------------------<u></u>Define Local Constant----------------------<u></u>-----*/<br>
> -//<br>
> -// Indicate different AP vendor for IOT issue.<br>
> -//<br>
> +/* */<br>
> +/* Indicate different AP vendor for IOT issue. */<br>
> +/* */<br>
> static u32 edca_setting_DL[HT_IOT_PEER_<u></u>MAX] =<br>
> { 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0xa44f, 0x5ea44f};<br>
> static u32 edca_setting_UL[HT_IOT_PEER_<u></u>MAX] =<br>
> @@ -36,11 +36,11 @@<br>
><br>
><br>
> /*------------------------<u></u>Define global variable----------------------<u></u>-------*/<br>
> -// Debug variable ?<br>
> 0 [/usr/src/linux-next] diff -u drivers/staging/rtl8192u/<u></u>r8192U_dm.c /tmp/z99 | wc -l<br>
> 1960<br>
<br>
What a mess, I'll gladly reject a patch that does this.<br>
<br>
Look at that multi-line crud.<br>
<br>
ick ick ick, don't run auto-formatting tools just to fix up checkpatch<br>
issues. If that was all that is needed, I would have done that a long<br>
time ago, that's not the goal here people...<br>
<br>
greg k-h<br>
</blockquote></div>