<p dir="ltr"><br>
</p>
<p dir="ltr"></p>
<p dir="ltr">On Thu, Dec 18, 2014, 12:37 AM Paul Bolle <<a href="mailto:pebolle@tiscali.nl">pebolle@tiscali.nl</a>> wrote:</p>
<blockquote><p dir="ltr">On Thu, 2014-12-18 at 00:04 +0530, karthik nayak wrote:<br>
> was trying to fix the checkpatch error of not using c99 comments in the<br>
> file<br>
> drivers/staging/rtl8192u/r8192U_dm.c<br>
> so I wrote a lex program to do so since there were way too many to do it<br>
> manually.<br>
> Could anyone have a look at my lex code and tell me if I need to change it.<br>
> I have attached the lex code.<br>
> As per my testing it works perfectly, would love a second opinion.</p>
<p dir="ltr">I see no reason to review someone's lex code. I guess very few people<br>
are actually willing to do that.</p>
<p dir="ltr">Why don't you just send in the diff? Or even better, the patch you<br>
intend to submit. Almost everybody here can read diffs or patches.</p>
<p dir="ltr">Hope this helps,<br></p>
<p dir="ltr">Paul Bolle</p>
</blockquote>
<p dir="ltr"><br>
</p>
<blockquote><p dir="ltr"><br>
</p>
</blockquote>
<p dir="ltr">Hello Paul,<br>
The only reason I didn't do that is cause the file is too large to manually have a look at, even the diff tends to be very huge.<br>
But if you think that would help, I wouldn't mind attaching the diff.<br>
Thanks<br>
Karthik</p>
<p dir="ltr"><br>
</p>