<p>Please also see line 596..<br>
file->private_data is buf and that is a string terminated by NULL.</p>
<p>thanks<br>
sudip</p>
<div class="gmail_quote">On Dec 2, 2014 9:45 PM, <<a href="mailto:land.ho87@gmail.com">land.ho87@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'm just reading the kernel source and came across this which doesn't look quite right to me:<br>
616 size_t size = strlen(file->private_data);<br>
<br>
strlen is used here when the pointer points to type:<br>
567 struct array_data {<br>
568 void *array;<br>
569 u32 elements;<br>
570 };<br>
<br>
I think line 616 should probably be something like:<br>
size_t size = file->private_data.elements*sizeof(u32);<br>
<br>
I think strlen would terminate incorrectly on any null byte, and is unnecessary<br>
since the data is already counted.<br>
<br>
Is this a legitimate criticism?<br>
<br>
_______________________________________________<br>
Kernelnewbies mailing list<br>
<a href="mailto:Kernelnewbies@kernelnewbies.org">Kernelnewbies@kernelnewbies.org</a><br>
<a href="http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies" target="_blank">http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies</a><br>
</blockquote></div>