<div dir="ltr">Ok, I will ask for a embedded powerpc board to test this. <div><br></div><div>Thanks</div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div dir="ltr"><div>--</div>Lucas Tanure <br>+55 (19) 988176559<br>
</div></div>
<br><br><div class="gmail_quote">On Thu, Jul 24, 2014 at 12:43 PM, <span dir="ltr"><<a href="mailto:Valdis.Kletnieks@vt.edu" target="_blank">Valdis.Kletnieks@vt.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="">On Thu, 24 Jul 2014 14:19:37 +0200, Kristof Provost said:<br>
> On 2014-07-24 09:00:22 (-0300), Lucas Tanure <<a href="mailto:tanure@linux.com">tanure@linux.com</a>> wrote:<br>
> > Line 2 of arch/arch/powerpc/boot/io.h :<br>
> ><br>
> > 1 #ifndef _IO_H<br>
> > 2 #define __IO_H<br>
> > 3<br>
> > 4 #include "types.h"<br>
> ><br>
> > Should be _IO_H, not __IO_H. I'm right ?<br>
> ><br>
> That certainly looks wrong. It's also been wrong since October 2006, so<br>
> it's probably not actually causing problems.<br>
<br>
</div>On the other hand, it would probably be a *really* good idea to test compile<br>
it on a powerpc box, see if it shakes out any latent bugs. All that fixing<br>
this will do is stop us from over-including io.h (and thus types.h) - but if<br>
there's any code that breaks because we don't include types.h and they don't<br>
pick it up otherwise.....<br>
<br>
(In other words, it's probably not causing a problem, but it *could* potentially<br>
be papering over a problem elsewhere...)<br>
</blockquote></div><br></div>