<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 11, 2013 at 3:55 PM, Prabhakar Lad <span dir="ltr"><<a href="mailto:prabhakar.csengg@gmail.com" target="_blank">prabhakar.csengg@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Oct 11, 2013 at 3:55 PM, Prabhakar Lad<br>
<<a href="mailto:prabhakar.csengg@gmail.com">prabhakar.csengg@gmail.com</a>> wrote:<br>
> On Fri, Oct 11, 2013 at 3:34 PM, Mandeep Sandhu<br>
> <<a href="mailto:mandeepsandhu.chd@gmail.com">mandeepsandhu.chd@gmail.com</a>> wrote:<br>
>><br>
>>> ><br>
>>> > Is it possible to use a github repository and just send a "please pull<br>
>>> > from git@github.com...." message to the kernel mailinglist, or will I<br>
>>> > be beaten for this?<br>
>>> ><br>
>>> You cannot directly send a pull request until the patches are reviewed,<br>
>>> once the the driver maintainer and other folks in the ML are happy, the<br>
>>> maintainer will pull your patches and get it merged in mainline kernel.<br>
>><br>
>><br>
>> If using github, I think send pull requests is a way to initiate a review.<br>
>> It does not mean that that pull request will be merged as-is. As you point<br>
>> out, if there are review comments, the reviewee will address those comments<br>
>> and send another pull request till the reviewer is satisfied. After that the<br>
>> reviewer just has to 'merge' the latest pull request.<br>
>><br>
><br>
> For reviewing patches on the mailing list you don't send pull request,<br>
> ! patches needs<br>
> to be sent to ML to be reviewed !.<br>
><br>
> For example look at [1] which is pull request to Linus. The pull request will<br>
> just have the patch description(it doesnt have the diff), and the link<br>
> to pull the patches from. People dont have time to go to your link and<br>
> review the<br>
> patches there and reply on your pull request.<br>
> "So you need to send patches to ML for review and not pull request"<br></div></div></blockquote><br></div>As I said above, this is the "github" workflow, not what Linux development might be using for handling contributions. Submitting patches to LKML might be the way it's done for Linux. I was merely pointing to the fact that if using github, pull requests are sufficient for doing reviews.<br>
<br></div><div class="gmail_extra">Hope that clarifies things.<br><br></div><div class="gmail_extra">-mandeep<br><br></div></div>